From: Shakeel Butt <shakeel.butt@linux.dev>
To: Harry Yoo <harry@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>, Tejun Heo <tj@kernel.org>,
Meta kernel team <kernel-team@meta.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-7.5 1/5] memcg: move memory.high enforcement out of try_charge_memcg()
Date: Mon, 12 Oct 2026 10:13:06 -0700 [thread overview]
Message-ID: <as0U-erMrDTG9fkt@linux.dev> (raw)
In-Reply-To: <aszdXDpqLUX1S4Qq@thinkstation>
On Mon, Oct 12, 2026 at 02:22:40PM +0100, Harry Yoo wrote:
> On Sat, Oct 10, 2026 at 02:09:53PM -0700, Shakeel Butt wrote:
> > try_charge_memcg() does a lot. It charges the page counters, reclaims
> > when a limit is hit, may call the OOM killer, and at the end it checks
> > and enforces memory.high. Move the memory.high part into a new function,
> > memcg_enforce_high(), so that try_charge_memcg() is shorter and the
> > memory.high code is easier to read and change.
> >
> > The code and its comments move as they are. The only difference is that
> > the new function gets allow_spinning from gfp_mask itself.
> >
> > No functional change.
> > ---
>
> Missing Signed-off-by: ?
Oh I don't know how I missed this.
>
> Otherwise LGTM.
> Reviewed-by: Harry Yoo (Meta) <harry@kernel.org>
Thanks for the review.
next prev parent reply other threads:[~2026-10-12 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 21:09 [PATCH for-7.5 0/5] memcg: clean up memory.high enforcement Shakeel Butt
2026-10-10 21:09 ` [PATCH for-7.5 1/5] memcg: move memory.high enforcement out of try_charge_memcg() Shakeel Butt
2026-10-12 13:22 ` Harry Yoo
2026-10-12 17:13 ` Shakeel Butt [this message]
2026-10-10 21:09 ` [PATCH for-7.5 2/5] memcg: use high_work for kernel threads Shakeel Butt
2026-10-10 21:09 ` [PATCH for-7.5 3/5] memcg: use high_work for remote charges Shakeel Butt
2026-10-10 21:09 ` [PATCH for-7.5 4/5] memcg: avoid queuing high_work from reclaim Shakeel Butt
2026-10-10 21:09 ` [PATCH for-7.5 5/5] memcg: simplify high limit handling after a charge Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as0U-erMrDTG9fkt@linux.dev \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=harry@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.