Re: [PATCH v10 00/16] drm/xe/hwmon: Update hwmon thermal mailbox

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Oct 12, 2026 at 06:33:46PM +0530, Karthik Poosa wrote:
> This series adds CRI-specific temperature sensor handling to the Xe
> hwmon implementation and fixes couple of hwmon issues.
> 
> CRI platforms may report unavailable temperature sensors and support
> a variable number of VRAM temperature channels depending on platform
> configuration. This series adds the required sensor presence checks and
> uses platform-reported thermal configuration data to expose only valid
> temperature-related hwmon attributes.
> 
> The series also corrects the telemetry group selection used for memory
> controller temperature reporting.
> 
> v2:
>  - Address review comments from Sashiko, Badal and Raag.
>  - Enable IEEE 754 temperature decoding for MMIO temperature registers.
>   - Split sensor validity check into mailbox vs MMIO handling; add
>     is_temp_available() / is_temp_is_visible().
>  - Temporarily disable memory controller and PCIe temperatures on CRI.
> 
> v3:
>   - Detect unavailable temperature sensors: rephrase a debug log.
>   - Decode mailbox temperatures as 8-bit sign-magnitude values instead of
>     s8.
>   - Use VRAM temperature sensor count from thermal config on CRI: address
>     review comments from sashiko-bot@kernel.org and Rodrigo.
>   - Decode CRI temperature registers as IEEE-754: reject temperatures that
>     overflow long on 32-bit systems.
> 
> v4:
>   - Address review comments and issues report from Rodrigo and
>     sashiko-bot@kernel.org.
>   - Decode mailbox temperatures as 8-bit sign-magnitude values.
>   - Cache sensor availability during registration.
>   - Enable memory controller and pcie sensors for CRI.
>   - Derive the VRAM channel count from the CRI MSU enable mask.
>   - Use CRI-specific package and VRAM temperature registers.
>   - Handle the CRI memory controller and pcie sensor offsets as per CRI.
> 
> v5:
>  - Remove the unintended IGT prefix from the patch titles.
> 
> v6:
>  - Address issues reported by sashiko-bot@kernel.org.
>  - Add VRAM individual channel CRI_VRAM_TEMPERATURE_N register for CRI.
> 
> v7:
>  - Address review comments from Rodrigo.
>     - Use ret instead of count in patch 1.
>     - Return true for platforms without temperature sentinels support.
>     - Rename has_mbx_temp_sentinel to has_temp_sentinel.
>     - Add a info flag for pcie sensor offset.
>     - Simplify temperature channels config.
> 
> v8:
>  - Address review comment from Sashiko.
>  - Revert the unconditional validation of temperature readings on
>    non-sentinel platforms.
>    This avoids creating spurious VRAM temperature channels when the
>    corresponding sensors are unavailable.
> 
> v9:
>  - Address review comment from Rodrigo.
>  - Use helper for pcie sensor offset instead of info field.
> 
> v10:
>  - Address review comments from sashiko.

for some reason I don't see CI results for this v10.

Could you please resubmit it?

Thanks,
Rodrigo.

> 
> Karthik Poosa (16):
>   drm/xe/hwmon: Handle pcode read failures of
>     xe_hwmon_pcode_rmw_power_limit
>   drm/xe/hwmon: Decode mailbox temperature as sign-magnitude
>   drm/xe/hwmon: Fix thermal sensor data handling
>   drm/xe/hwmon: Add helpers to validate thermal sensor readings
>   drm/xe/hwmon: Handle unavailable memory controller sensors
>   drm/xe/hwmon: Detect unavailable PCIe thermal sensors
>   drm/xe/hwmon: Consolidate temperature sensor availability checks
>   drm/xe/hwmon: Cache temperature availability to reduce probe time
>   drm/xe/hwmon: use CRI-specific package and VRAM temperature registers
>   drm/xe/hwmon: Add platform-aware VRAM thermal channel support
>   drm/xe/hwmon: Decode CRI temperature registers as IEEE-754
>   drm/xe/hwmon: Update memory controller temperature offset for CRI
>   drm/xe/hwmon: add PCIe temperature support for CRI
>   drm/xe/hwmon: Simplify temperature channels config
>   drm/xe: Validate thermal sensor count  before reads
>   drm/xe/hwmon: Propagate all hardware read errors
> 
>  drivers/gpu/drm/xe/regs/xe_pcode_regs.h |   4 +
>  drivers/gpu/drm/xe/xe_device_types.h    |   4 +
>  drivers/gpu/drm/xe/xe_hwmon.c           | 525 ++++++++++++++++++------
>  drivers/gpu/drm/xe/xe_pci.c             |   4 +
>  drivers/gpu/drm/xe/xe_pci_types.h       |   2 +
>  drivers/gpu/drm/xe/xe_pcode_api.h       |   2 -
>  6 files changed, 416 insertions(+), 125 deletions(-)
> 
> -- 
> 2.25.1
>