Re: [Buildroot] [PATCH] package/umtprd: expose package build options

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Nevo,

Thanks a lot for your patch, and sorry for the delay! See below some
review.

On Thu, Jun 04, 2026 at 09:14:01PM +0000, Nevo Hed via buildroot wrote:
> Primary impetus: BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY:
>     By default umtprd does not communicate daemon readyness.  Version
>     1.6.8 added a build option that enables creating a Type=notify
>     systemd service.
> 
> Added two other relevant build options that were available in the
> Makefile:
> - BR2_PACKAGE_UMTPRD_DEBUG
> - BR2_PACKAGE_UMTPRD_SYSLOG
> 
> Signed-off-by: Nevo Hed <nhed+buildroot@starry.com>
> ---
>  package/umtprd/Config.in | 19 ++++++++++++++++++-
>  package/umtprd/umtprd.mk | 14 +++++++++++++-
>  2 files changed, 31 insertions(+), 2 deletions(-)
> 
> diff --git a/package/umtprd/Config.in b/package/umtprd/Config.in
> index 24bf119549..dff5a44583 100644
> --- a/package/umtprd/Config.in
> +++ b/package/umtprd/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_UMTPRD
> +menuconfig BR2_PACKAGE_UMTPRD
>  	bool "umtprd"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
> @@ -7,5 +7,22 @@ config BR2_PACKAGE_UMTPRD
>  
>  	  https://github.com/viveris/uMTP-Responder
>  
> +if BR2_PACKAGE_UMTPRD
> +
> +if BR2_PACKAGE_SYSTEMD
> +
> +config BR2_PACKAGE_UMTPRD_SYSTEMD_NOTIFY
> +	bool "Tell Systemd when uMTP-Responder is ready "

There is no need to have a separate option for this, just enable
systemd notify support at soon as BR2_PACKAGE_SYSTEMD=y.

> +endif
> +
> +config BR2_PACKAGE_UMTPRD_DEBUG
> +	bool "Enable debug"

What does it do? Perhaps we want to use BR2_ENABLE_RUNTIME_DEBUG=y
instead of having a custom option?

> +config BR2_PACKAGE_UMTPRD_SYSLOG
> +	bool "Send output to syslog"

Where is the output going otherwise? Shouldn't sending the output to
syslog simply be the unconditional default?

Peter, Arnout, any opinion on this?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot