From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3994DCC6B12 for ; Tue, 13 Oct 2026 18:41:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGhQt-00080L-2O; Tue, 13 Oct 2026 14:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhQr-0007xH-Gz for qemu-devel@nongnu.org; Tue, 13 Oct 2026 14:41:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhQp-0003TJ-Mj for qemu-devel@nongnu.org; Tue, 13 Oct 2026 14:41:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791916856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8l6zsNG9J8q3SUyRsy4zgN2QrqewKePqmmk0OAKPFVA=; b=esHLXNyBy1B+rLHQhjNYODUBRMIq4nt7iWF4uLEFV7uYaojSU2nQgYT96zDuMEp2ZxUmfj xdycaIdLJATN5LQ67jD9cTd07f7ylVUbuQBrGC2v2HrfBv8wdn6Tz9XfTsymfnP/J8yUBa iwK6GHajkmIrrvdDibLZE8Y7OW8WL50= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-GSbqY3wPMyOYcJuAeuZh5A-1; Tue, 13 Oct 2026 18:40:53 +0000 X-MC-Unique: GSbqY3wPMyOYcJuAeuZh5A-1 X-Mimecast-MFC-AGG-ID: GSbqY3wPMyOYcJuAeuZh5A_1791916852 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C64861955E92; Tue, 13 Oct 2026 18:40:51 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B4B4930001B9; Tue, 13 Oct 2026 18:40:48 +0000 (UTC) Date: Tue, 13 Oct 2026 13:40:45 -0500 From: Eric Blake To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, akalenyu@redhat.com, qemu-block@nongnu.org, Pierrick Bouvier , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Paolo Bonzini , Benjamin Marzinski , Hanna Reitz , Kevin Wolf , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Fam Zheng Subject: Re: [PATCH 8/8] scsi: use REGISTER AND IGNORE EXISTING KEY for robustness Message-ID: References: <20261009153058.1089786-1-stefanha@redhat.com> <20261009153058.1089786-9-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261009153058.1089786-9-stefanha@redhat.com> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 09, 2026 at 11:30:58AM -0400, Stefan Hajnoczi wrote: > The regular REGISTER service action fails with RESERVATION CONFLICT when > the I_T nexus already has a key registered. While we don't expect a key > to be registered, it is fragile to rely on this. If there is a key > registered for some reason, live migration will fail when the > destination hits the RESERVATION CONFLICT error. > > Use REGISTER AND IGNORE EXISTING KEY so that the command is likely to > succeed. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-generic.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org