From: Keith Busch <kbusch@kernel.org>
To: Martin George <martinus.gpy@gmail.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
loberman@redhat.com, Martin George <marting@netapp.com>
Subject: Re: [PATCH] nvme-multipath: report "none" iopolicy for discovery subsystems
Date: Tue, 13 Oct 2026 09:36:12 -0600 [thread overview]
Message-ID: <as5P7PlWYWA8exrX@kbusch-mbp> (raw)
In-Reply-To: <20260930153658.4002-1-marting@netapp.com>
On Wed, Sep 30, 2026 at 09:06:58PM +0530, Martin George wrote:
> A discovery subsystem never exposes namespaces, so it has no multipath
> head and no I/O paths to select between. Nevertheless the per-subsystem
> iopolicy attribute is registered unconditionally and reads back the
> driver-wide default which is 'numa' for the discovery subsystems too.
> This can be misleading as it suggests a path selection policy is in
> effect when nothing is ever selected, and writing the attribute silently
> mutates state that can never be used.
>
> Report "none" instead for a discovery subsystem, and reject writes
> with -EOPNOTSUPP. Report "none" from iopolicies as well, so that the
> value read from iopolicy always remains a member of the set advertised
> by iopolicies; otherwise userspace validating the current policy
> against the available ones would reject its own subsystem.
>
> And while at it, document iopolicies too, which was not covered when it
> was added previously.
Thanks, applied to nvme-7.4.
prev parent reply other threads:[~2026-10-13 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 15:36 [PATCH] nvme-multipath: report "none" iopolicy for discovery subsystems Martin George
2026-09-30 16:00 ` Laurence Oberman
2026-10-13 14:37 ` Christoph Hellwig
2026-10-13 15:36 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as5P7PlWYWA8exrX@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=marting@netapp.com \
--cc=martinus.gpy@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.