From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B10CC6B12 for ; Tue, 13 Oct 2026 18:58:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGhho-0003BS-J4; Tue, 13 Oct 2026 14:58:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhhn-0003BJ-Us for qemu-devel@nongnu.org; Tue, 13 Oct 2026 14:58:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhhm-0005Ee-IZ for qemu-devel@nongnu.org; Tue, 13 Oct 2026 14:58:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791917910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xseXA7Wu7nGu+84RizEkhujybgGls9Waxq7DRAXocik=; b=JsNDoMMLuZkX4rrKHKJkUhzQ9b33w5turDl+XU/WbbrtQrb6heCeiui94upITiAh3nx6v5 k96rx5Ef46aU/f0ECvlPuongnSc28LsPgj4jop9Dl+4VcEvV1mrmVNIDHe5HMUx2Ri4kPy FgkVSMXmTcsHu7hYBBst/leVvePOXv0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-nOQROtNENx6sp6LLpbDO8Q-1; Tue, 13 Oct 2026 18:58:26 +0000 X-MC-Unique: nOQROtNENx6sp6LLpbDO8Q-1 X-Mimecast-MFC-AGG-ID: nOQROtNENx6sp6LLpbDO8Q_1791917906 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB98819541B4; Tue, 13 Oct 2026 18:58:25 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 282A8195608E; Tue, 13 Oct 2026 18:58:24 +0000 (UTC) Date: Tue, 13 Oct 2026 13:58:21 -0500 From: Eric Blake To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Hanna Reitz Subject: Re: [PATCH] block: fix leak of block histogram data Message-ID: References: <20261012114400.206772-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261012114400.206772-1-berrange@redhat.com> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Oct 12, 2026 at 12:43:59PM +0100, Daniel P. Berrangé wrote: > The block_acct_cleanup method failed to release memory associated > with block histograms. > > Fixes: b741ae7417 (block/accounting: introduce latency histogram) > Signed-off-by: Daniel P. Berrangé > --- > block/accounting.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Eric Blake > > diff --git a/block/accounting.c b/block/accounting.c > index 038af370170..40ed70782b4 100644 > --- a/block/accounting.c > +++ b/block/accounting.c > @@ -80,6 +80,13 @@ bool block_acct_setup(BlockAcctStats *stats, enum OnOffAuto account_invalid, > void block_acct_cleanup(BlockAcctStats *stats) > { > BlockAcctTimedStats *s, *next; > + size_t i; > + for (i = 0; i < BLOCK_MAX_IOTYPE; i++) { > + BlockLatencyHistogram *hist = &stats->latency_histogram[i]; > + g_free(hist->bins); > + g_free(hist->boundaries); > + } > + > QSLIST_FOREACH_SAFE(s, &stats->intervals, entries, next) { > g_free(s); > } > -- > 2.56.0 > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org