From: Thierry Reding <thierry.reding@kernel.org>
To: phucduc.bui@gmail.com
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
kwilczynski@kernel.org, Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Manikanta Maddireddy <mmaddireddy@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
Niklas Cassel <cassel@kernel.org>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors
Date: Tue, 13 Oct 2026 18:21:21 +0200 [thread overview]
Message-ID: <as5adjyCjltieSWK@orome> (raw)
In-Reply-To: <20261012094815.28160-2-phucduc.bui@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Mon, Oct 12, 2026 at 04:48:15PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> devm_gpiod_get_optional() returns NULL when the optional GPIO is not
> present, but may return -EPROBE_DEFER or other errors.
>
> The current code treats GPIO lookup errors as if the GPIO were not
> present.
>
> Check the return value and propagate errors from the REFCLK select GPIO
> lookup.
>
> Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>
> Changes in v2:
> - Follow the subject line capitalization style.
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 15 +++------------
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-10-13 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 9:48 [PATCH v2 1/2] PCI: tegra194: Use dev_err_probe() for PERST# GPIO phucduc.bui
2026-10-12 9:48 ` [PATCH v2 2/2] PCI: tegra194: Propagate REFCLK select GPIO errors phucduc.bui
2026-10-12 9:53 ` sashiko-bot
2026-10-13 16:21 ` Thierry Reding [this message]
2026-10-12 9:54 ` [PATCH v2 1/2] PCI: tegra194: Use dev_err_probe() for PERST# GPIO sashiko-bot
2026-10-13 16:20 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as5adjyCjltieSWK@orome \
--to=thierry.reding@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=phucduc.bui@gmail.com \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.