All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bobby Eshleman <bobbyeshleman@meta.com>
To: Daniel Pereira <danielmaraboo@gmail.com>
Cc: <sgarzare@redhat.com>, <davem@davemloft.net>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <horms@kernel.org>, <corbet@lwn.net>,
	<skhan@linuxfoundation.org>, <stefanha@redhat.com>,
	<mst@redhat.com>, <jasowangio@gmail.com>,
	<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
	<shuah@kernel.org>, <rdunlap@infradead.org>,
	<donald.hunter@gmail.com>, <edumazet@kernel.org>,
	<virtualization@lists.linux.dev>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<kvm@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<sargun@sargun.me>, <jlinbox@meta.com>
Subject: Re: [PATCH net-next v3 4/7] vsock: add a netlink command to assign the g2h device to a netns
Date: Tue, 13 Oct 2026 10:34:26 -0700	[thread overview]
Message-ID: <as5roqKrcZ+0WYIj@devvm29614.prn0.facebook.com> (raw)
In-Reply-To: <CAMAsx6fKVQaYLzkK34v5DRkmQS5Ym-XqwNh-+Jj_Uue8NJCNUg@mail.gmail.com>

On Mon, Oct 12, 2026 at 10:44:55PM -0300, Daniel Pereira wrote:
> Em seg., 12 de out. de 2026 às 19:51, Bobby Eshleman
> <bobbyeshleman@meta.com> escreveu:
> >
> [...]
> > + Movement to an unreachable local namespace results in sockets being
> > + closed with ECONNRESET. Peers are not guaranteed to be notified via
> > + an RST.
> 
> This reads a bit differently from the sysctl documentation in the same
> patch, which says:
> 
> Connections established before the move, from a namespace that can no
> longer reach the device, are closed with ``ECONNRESET``.
> 
> The net.rst wording also covers moving the device back to init_net from
> a local namespace, which this sentence does not. Maybe use the same
> wording here:
> 
> Connections established before the move, from a namespace that can
> no longer reach the device, are closed with ECONNRESET. Peers are not
> guaranteed to be notified via an RST.
> 
> Daniel

Thanks Daniel, I forgot to update the docs with that change. Your
rewording sounds good to me.

Best,
Bobby

  reply	other threads:[~2026-10-13 17:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 22:48 [PATCH net-next v3 0/7] vsock: assign the guest vsock device to a network namespace Bobby Eshleman
2026-10-12 22:48 ` [PATCH net-next v3 1/7] vsock: constify the transport in vsock_for_each_connected_socket() Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-12 22:48 ` [PATCH net-next v3 2/7] vsock: rename the vsock pernet operations Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-12 22:48 ` [PATCH net-next v3 3/7] vsock: pass the netns to ->has_remote_cid() Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-12 22:48 ` [PATCH net-next v3 4/7] vsock: add a netlink command to assign the g2h device to a netns Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-13  1:44   ` Daniel Pereira
2026-10-13 17:34     ` Bobby Eshleman [this message]
2026-10-13 22:51   ` netdev-bot+sashiko
2026-10-12 22:48 ` [PATCH net-next v3 5/7] vsock/virtio: support guest device network namespace Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-13 22:51   ` netdev-bot+sashiko
2026-10-12 22:48 ` [PATCH net-next v3 6/7] selftests/vsock: test the guest vsock " Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-13 22:51   ` netdev-bot+sashiko
2026-10-12 22:48 ` [PATCH net-next v3 7/7] selftests/vsock: test the netns assign privilege checks Bobby Eshleman
2026-10-12 23:05   ` sashiko-bot
2026-10-13 22:52   ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as5roqKrcZ+0WYIj@devvm29614.prn0.facebook.com \
    --to=bobbyeshleman@meta.com \
    --cc=corbet@lwn.net \
    --cc=danielmaraboo@gmail.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=horms@kernel.org \
    --cc=jasowangio@gmail.com \
    --cc=jlinbox@meta.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=sargun@sargun.me \
    --cc=sgarzare@redhat.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.