From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AE08CC6B1A for ; Tue, 13 Oct 2026 19:17:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGhzf-0007JS-VN; Tue, 13 Oct 2026 15:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhze-0007JB-Gu for qemu-devel@nongnu.org; Tue, 13 Oct 2026 15:16:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGhzd-00071i-6k for qemu-devel@nongnu.org; Tue, 13 Oct 2026 15:16:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791919015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TaabHNh5sIplria81wm7zJ/PLsGoNTOduwN4dIurvrU=; b=RfKPznot4Wmsir9VH3XUaHOSqr05E9/3NRBWVXRH3z8l1PTdGd1R+Rx/VRbXs5+LkIL4dO gLnXuxY40Dypn/pUmDQrvCf5Kr5A4i4P+N9RceWySmLraWwboIQgiwh0MWhfiI6QMshLC7 CwwSz4qnQtBswsW6NJumxbnSpQF617Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-Wmozrd87P5KNvmM8rlHeSA-1; Tue, 13 Oct 2026 19:16:52 +0000 X-MC-Unique: Wmozrd87P5KNvmM8rlHeSA-1 X-Mimecast-MFC-AGG-ID: Wmozrd87P5KNvmM8rlHeSA_1791919011 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B99DA1955F56; Tue, 13 Oct 2026 19:16:50 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 074D71956095; Tue, 13 Oct 2026 19:16:47 +0000 (UTC) Date: Tue, 13 Oct 2026 14:16:45 -0500 From: Eric Blake To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Pierrick Bouvier , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , akalenyu@redhat.com, Kevin Wolf , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Fam Zheng , Paolo Bonzini , qemu-block@nongnu.org, Hanna Reitz , Benjamin Marzinski Subject: Re: [PATCH v2 3/8] hw/scsi-disk: move MIG_EVENT_FAILED into a new function Message-ID: References: <20261013181752.1299456-1-stefanha@redhat.com> <20261013181752.1299456-4-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013181752.1299456-4-stefanha@redhat.com> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 13, 2026 at 02:17:47PM -0400, Stefan Hajnoczi wrote: > Move the MIG_EVENT_FAILED logic from scsi_block_migration_notifier() > into its own new scsi_block_migration_failed() function. The next commit > adds logic for handling another event, so doing that in dedicated > functions makes the code easier to read. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-disk.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org