From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 494D8CC6B12 for ; Tue, 13 Oct 2026 20:05:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGikU-0007d2-Jf; Tue, 13 Oct 2026 16:05:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGikS-0007Zd-Qp for qemu-devel@nongnu.org; Tue, 13 Oct 2026 16:05:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGikR-0003LL-Bp for qemu-devel@nongnu.org; Tue, 13 Oct 2026 16:05:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791921918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E6Rz9v6oqiQUcqsjgM3jkVQy96YrFiTxmj7qvwbYm/Y=; b=XspToVrXGzhKt+4PCBe0AAqV7zVUafmNTF6czjcJfiudPIBFe9NwV0TbnjO9I3aowg+r2A kBJO/emSNX70BATDgsU0NFHIpfXYkt/M5SShCoV/Ttke0qHPqPnVaFubzLHz9BReNjP8AG yew3nc9bKYnkdfqdQnYcFakz+QGNEHk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-vsKJZEo7PUuIBrFqawArYw-1; Tue, 13 Oct 2026 20:05:14 +0000 X-MC-Unique: vsKJZEo7PUuIBrFqawArYw-1 X-Mimecast-MFC-AGG-ID: vsKJZEo7PUuIBrFqawArYw_1791921913 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 987181802141; Tue, 13 Oct 2026 20:05:13 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 44A68195608E; Tue, 13 Oct 2026 20:05:10 +0000 (UTC) Date: Tue, 13 Oct 2026 15:05:08 -0500 From: Eric Blake To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Pierrick Bouvier , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , akalenyu@redhat.com, Kevin Wolf , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Fam Zheng , Paolo Bonzini , qemu-block@nongnu.org, Hanna Reitz , Benjamin Marzinski Subject: Re: [PATCH v2 8/8] scsi: use REGISTER AND IGNORE EXISTING KEY for robustness Message-ID: References: <20261013181752.1299456-1-stefanha@redhat.com> <20261013181752.1299456-9-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013181752.1299456-9-stefanha@redhat.com> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 13, 2026 at 02:17:52PM -0400, Stefan Hajnoczi wrote: > The regular REGISTER service action fails with RESERVATION CONFLICT when > the I_T nexus already has a key registered. While we don't expect a key > to be registered, it is fragile to rely on this. If there is a key > registered for some reason, live migration will fail when the > destination hits the RESERVATION CONFLICT error. > > Use REGISTER AND IGNORE EXISTING KEY so that the command is likely to > succeed. > > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-generic.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org