From: Jisheng Zhang <jszhang@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dw: Fix missing smp_mb() in dw_spi_exec_mem_op
Date: Wed, 14 Oct 2026 12:15:51 +0800 [thread overview]
Message-ID: <as8B9-ypMid1IV9E@xhacker> (raw)
In-Reply-To: <f4fe920a-7b2b-4c6d-bf41-a7935e6e5574@sirena.org.uk>
On Tue, Oct 13, 2026 at 11:10:09PM +0100, Mark Brown wrote:
> On Sat, Oct 10, 2026 at 11:15:29PM +0800, Jisheng Zhang wrote:
>
> > Similar as commit bfda044533b2 ("spi: dw: use "smp_mb()" to avoid
> > sending spi data error"), we also need the smp_mb() in
> > dw_spi_exec_mem_op() after setting up the members in "dws" to ensure
> > the data change is visible for all CPUs.
>
> Which other CPUs are we worried about here? Unlike the regular SPI path
> which can use DMA and interrupts for the exec_op() stuff we only do PIO
> and have interrupts masked during the actual transfer. If the task
> migrates I'd expect that to have all the required barriers, but
> otherwise it all looks single threaded.
You are right. This patch isn't needed. Thanks for the explaination.
prev parent reply other threads:[~2026-10-14 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 15:15 [PATCH] spi: dw: Fix missing smp_mb() in dw_spi_exec_mem_op Jisheng Zhang
2026-10-13 22:10 ` Mark Brown
2026-10-14 4:15 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as8B9-ypMid1IV9E@xhacker \
--to=jszhang@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.