From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Satyam Gupta <sgsatyam@google.com>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Scott Collyer <scollyer@google.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_sensorhub: Increase MAX_DRIFT_PPM to 5000LL
Date: Wed, 14 Oct 2026 06:49:20 +0000 [thread overview]
Message-ID: <as8l8OYwgCr7rv3k@google.com> (raw)
In-Reply-To: <20261013105806.1371175-1-sgsatyam@google.com>
On Tue, Oct 13, 2026 at 10:58:06AM +0000, Satyam Gupta wrote:
> diff --git a/drivers/platform/chrome/cros_ec_sensorhub_ring.c b/drivers/platform/chrome/cros_ec_sensorhub_ring.c
> index 20fa47cbee32..a5215955470f 100644
> --- a/drivers/platform/chrome/cros_ec_sensorhub_ring.c
> +++ b/drivers/platform/chrome/cros_ec_sensorhub_ring.c
> @@ -22,7 +22,7 @@
>
> /* Precision of fixed point for the m values from the filter */
> #define M_PRECISION BIT(23)
> -#define MAX_DRIFT_PPM 200LL
> +#define MAX_DRIFT_PPM 5000LL
> #define MAX_M ((s64)(MAX_DRIFT_PPM * M_PRECISION / 1000000))
>
> /* Only activate the filter once we have at least this many elements. */
> @@ -278,7 +278,7 @@ cros_ec_sensor_ring_ts_filter_update(struct cros_ec_sensors_ts_filter_state
> dy = (state->y_history[0] + state->y_offset) - y;
> m = div64_s64(dy * M_PRECISION, dx);
> /*
> - * Clamp the calculated slope to a realistic range (+/- 200 ppm).
> + * Clamp the calculated slope to a realistic range (+/- 5000 ppm).
> * Temporary large jitter spikes can produce huge slopes (e.g. +/- 20000 ppm)
> * that would otherwise corrupt the median filter history.
> */
Applying: platform/chrome: cros_ec_sensorhub: Increase MAX_DRIFT_PPM to 5000LL
error: patch failed: drivers/platform/chrome/cros_ec_sensorhub_ring.c:22
error: drivers/platform/chrome/cros_ec_sensorhub_ring.c: patch does not apply
Until I realized this should apply after [1].
NACK, you should either form them a series or squash the fix into [1].
[1] https://lore.kernel.org/all/20261013105753.1370713-1-sgsatyam@google.com
prev parent reply other threads:[~2026-10-14 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:58 [PATCH] platform/chrome: cros_ec_sensorhub: Increase MAX_DRIFT_PPM to 5000LL Satyam Gupta
2026-10-14 6:49 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as8l8OYwgCr7rv3k@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scollyer@google.com \
--cc=sgsatyam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.