Re: [PATCH] firmware: efi: add a separate timeout for UpdateCapsule()

[Yeoreum Yun <yeoreum.yun@arm.com>]

> On Thu, Sep 17, 2026 at 05:01:20PM +0100, Yeoreum Yun wrote:
> > > > Could there be any issues with doing it this way, or would there be
> > > > a better approach?
> > > >
> > > 
> > > Would it make sense to simply have different limits for UpdateCapsule() and
> > > for everything else? How much longer than 2 minutes do you need in the
> > > typical case?
> > 
> > Although the time required to complete a firmware update depends onthe platform
> > and other factors, such as whether the capsule contains a single firmware image
> > or multiple images, it is generally reasonable to expect the update to complete
> > within 10 minutes.
> > 
> > If, for some reason, an update is expected to take longer than 10 minutes,
> > the sysfs interface for configuring capsule_update_timeout would be useful.
> > 
> > This would allow the timeout to be adjusted as needed, for example to
> > 15 minutes, before capsule update. 
> 
> In this case, if you have a worker that takes 10-15 minutes, will not 
> the workqueue stall kick in ?

Hi Breno,

Sorry for the late reply. I was on holiday.

If the default value of 30 seconds is used, it would trigger the workqueue
stall warning. However, AFAIK, wq_watchdog_thresh is configurable, and
platforms where the operation is expected to take longer than 30 seconds
should configure it accordingly.

What I want to tell is  capsule update timeout should be configurable
depending on the use case, rather than hardcoded at least.

Thanks.


-- 
Sincerely,
Yeoreum Yun