From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A07DCC6B1A for ; Wed, 14 Oct 2026 12:11:18 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 54E2E3EA790 for ; Wed, 14 Oct 2026 14:11:16 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id A0E2D3E29CE for ; Wed, 14 Oct 2026 14:10:59 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 33965200B06 for ; Wed, 14 Oct 2026 14:10:58 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A362B21D11; Wed, 14 Oct 2026 12:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1791979857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlhofENmqYF2/DWKlmZeJ2bBKYX6e9AjNu11WEfiQ1A=; b=tTJUKFfHYRJGAeyTFQCMV47buIEloFFWmcIwxY0BviFRHWaunvWyM8e/+2cOtZMwWFO9Fy d31E0Q98+IMOxiHb47zPoV8Xzr8/ne7dkq9AI73LYEd8SOif2mMsQMNwcByyc/0hhUqIud ZhU1uTys7p/XpMG0a9apHvvqYrHNdqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1791979857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlhofENmqYF2/DWKlmZeJ2bBKYX6e9AjNu11WEfiQ1A=; b=dncbzpAC9MVb1zLbNVtIMK7fvAfSJWBDDUQLiFAcz7FOJbKmfMFsYSp2YWz1m36glODhCT YXtfwubgxYHbwVAQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tTJUKFfH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dncbzpAC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1791979857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlhofENmqYF2/DWKlmZeJ2bBKYX6e9AjNu11WEfiQ1A=; b=tTJUKFfHYRJGAeyTFQCMV47buIEloFFWmcIwxY0BviFRHWaunvWyM8e/+2cOtZMwWFO9Fy d31E0Q98+IMOxiHb47zPoV8Xzr8/ne7dkq9AI73LYEd8SOif2mMsQMNwcByyc/0hhUqIud ZhU1uTys7p/XpMG0a9apHvvqYrHNdqo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1791979857; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlhofENmqYF2/DWKlmZeJ2bBKYX6e9AjNu11WEfiQ1A=; b=dncbzpAC9MVb1zLbNVtIMK7fvAfSJWBDDUQLiFAcz7FOJbKmfMFsYSp2YWz1m36glODhCT YXtfwubgxYHbwVAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3F8691368E; Wed, 14 Oct 2026 12:10:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JTP2M1Bxz2oZZAAAD6G6ig (envelope-from ); Wed, 14 Oct 2026 12:10:57 +0000 Date: Wed, 14 Oct 2026 14:11:15 +0200 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20260831-fchroot-v4-0-57cceb68f927@suse.com> <20260831-fchroot-v4-13-57cceb68f927@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260831-fchroot-v4-13-57cceb68f927@suse.com> X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.cz:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Queue-Id: A362B21D11 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH STAGING v4 13/16] fchroot10: test failfs entry without no_new_privs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Test Project Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +static void run(void) > +{ > + if (SAFE_FORK()) > + return; > + > + SAFE_SETRESUID(ltpuser->pw_uid, ltpuser->pw_uid, > + ltpuser->pw_uid); > + > + TST_EXP_FAIL(tst_syscall(__NR_fchroot, FD_FAILFS_ROOT, 0), > + EPERM, "unprivileged fchroot() without no_new_privs"); > + > + exit(0); Here as well, no need for the exit(0) Otherwise: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp