From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EFAC3C416B for ; Fri, 2 Oct 2026 19:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968397; cv=none; b=ldeEzIsPicWLfab6pstP+2fjV8a8Lual+cwDwO34UZneUsmMRNVuDhsH4P1COiQXwaP52QA23p5s9hspMW627wxtHvqoM1s0qlHLHZ1ED/Q2i88oLQ405W8kI8Kv7YbKOxaRTxEufS63kADPh/CrgEpdG8w9sv2tIFP+GM71ILI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968397; c=relaxed/simple; bh=7AnLrCmmGzfchlsQUVsMdpXNPd+PRgZIb806oL1ig9g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VFOOFCbxi4EDElOo+0vtez3m8Jz+q40zyGbQDCQd/sNLYgp/XSYOiS8qj7b5F46eSF/EAQJKF04Ckj9x2C+MGIoE8Hv4vA1d/OP36Z6y0XNfuuJy7WyTAnIZtbOWFCt9p+OIxrcijuxGESt5JLaL61qQLmymniOymkNx/4ON5co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Yo2N2pCz; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Yo2N2pCz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790968395; x=1822504395; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7AnLrCmmGzfchlsQUVsMdpXNPd+PRgZIb806oL1ig9g=; b=Yo2N2pCzteqV1p/N3ssKSN3KrPRJ5nPLF7iMVVdBF9B42vbynr0+RWLJ WX0YclRpNwqkytCzAWUS7BhHTw3RnNPMYzueV0FA9QL9gNTdUcNFKionj VQja078kb03eMzH1F0lXYuI7lAzV27Ct0KhloHNFFkYQgxmWhPUpt9lAe PQScrH1Zlynjt+KVRW0oruVJbaiz2NpHlBQ8Qxa7txNdJ42pwa8rK8osU mEG2TjlSkuAqRM4S+f3Us8aH8gigjF43AZL/qmjRaBBa02ynqQl7Oq4Ir UpwKPewmgtH5oT3BCt2QKTOh8UYiK2nwElV8I9BzLy/SwqVP+up94ku/j A==; X-CSE-ConnectionGUID: VJwNoSCwSWu0pLjkEL8u0g== X-CSE-MsgGUID: iRSsj63XS8Owcmj5v4ZTTw== X-IronPort-AV: E=McAfee;i="6800,10657,11923"; a="90798373" X-IronPort-AV: E=Sophos;i="6.27,136,1787036400"; d="scan'208";a="90798373" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2026 12:13:15 -0700 X-CSE-ConnectionGUID: Pl1yrAxIR8anZl9RQR/gRA== X-CSE-MsgGUID: 05IIsST2Sem5PW7hPGKocA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,136,1787036400"; d="scan'208";a="284379841" Received: from conormcd-mobl2.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.45]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2026 12:13:12 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id D8C07121BB9; Fri, 02 Oct 2026 22:13:09 +0300 (EEST) Date: Fri, 2 Oct 2026 22:13:09 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Andy Shevchenko Cc: Maurizio Casciano , mchehab@kernel.org, linux-media@vger.kernel.org, bingbu.cao@amd.com, jacopo.mondi@ideasonboard.com, nicholas@rothemail.net, andy@kernel.org, hansg@kernel.org, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 02/16] media: ov8858: support 19.2 MHz clock and CHT gain setup Message-ID: References: <628adb1cabec866554ca26a2da5af860b04d6cb1.1788360629.git.mauriziocasciano7@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Oct 02, 2026 at 10:14:29AM +0300, Andy Shevchenko wrote: > > > +#define OV8858_LINK_FREQ (360 * HZ_PER_MHZ) > > > +#define OV8858_XVCLK_FREQ_24MHZ 24000000 > > > +#define OV8858_XVCLK_FREQ_19_2MHZ 19200000 > > > > Why to use HZ_PER_MHZ for LINK_FREQ but not the rest? > > Because we do not do floats in the kernel. And hence for the consistency's > sake. Floating point operations won't end up in generated code even if you have floating point numbers here -- it's an integer constant. -- Sakari Ailus