From: Patrick Steinhardt <ps@pks.im>
To: "Mark C. Chu-Carroll" <markchucarroll@fastmail.com>
Cc: git@vger.kernel.org,
Guillaume Chauvel <guillaume.chauvel@gmail.com>,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH 1/2] packfile: move around `close_pack()`
Date: Fri, 2 Oct 2026 21:38:07 +0200 [thread overview]
Message-ID: <asAIH5JOfGMpJqEN@pks.im> (raw)
In-Reply-To: <DLUL2YDALTAV.15LO4AB7BDMLR@fastmail.com>
On Fri, Oct 02, 2026 at 03:02:30PM -0400, Mark C. Chu-Carroll wrote:
> On Fri Oct 2, 2026 at 3:34 AM EDT, Patrick Steinhardt wrote:
> > In the next commit we'll want to access the delta base cache in
> > `close_pack()`. Move the function after the declaration of the cache to
> > prepare for this.
>
> Maybe I'm just being clueless, but how does moving an unmodified function
> help with the subsequent change?
This is mostly done to avoid a forward declaration of the function that
would otherwise be necessary.
Patrick
next prev parent reply other threads:[~2026-10-02 19:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:34 [PATCH 0/2] packfile: fix corruption due to stale delta base cache entries Patrick Steinhardt
2026-10-02 7:34 ` [PATCH 1/2] packfile: move around `close_pack()` Patrick Steinhardt
2026-10-02 19:02 ` Mark C. Chu-Carroll
2026-10-02 19:38 ` Patrick Steinhardt [this message]
2026-10-02 7:34 ` [PATCH 2/2] packfile: fix corruption due to stale delta base cache entries Patrick Steinhardt
2026-10-02 13:34 ` Guillaume Chauvel
2026-10-02 19:34 ` Patrick Steinhardt
2026-10-02 17:48 ` Philippe Blain
2026-10-02 19:37 ` Patrick Steinhardt
2026-10-02 22:23 ` Jeff King
2026-10-05 5:32 ` Patrick Steinhardt
2026-10-07 8:18 ` Jeff King
2026-10-07 18:00 ` Junio C Hamano
2026-10-06 10:20 ` [PATCH v2 0/2] " Patrick Steinhardt
2026-10-06 10:20 ` [PATCH v2 1/2] packfile: move around `close_pack()` Patrick Steinhardt
2026-10-06 10:20 ` [PATCH v2 2/2] packfile: fix corruption due to stale delta base cache entries Patrick Steinhardt
2026-10-06 19:57 ` Junio C Hamano
2026-10-07 5:29 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asAIH5JOfGMpJqEN@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=guillaume.chauvel@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=markchucarroll@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.