All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"michal.simek@amd.com" <michal.simek@amd.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] usb: dwc3: xilinx: error path and teardown fixes
Date: Fri, 2 Oct 2026 21:27:39 +0000	[thread overview]
Message-ID: <asAhNsmiBunddm-W@vbox> (raw)
In-Reply-To: <20260928120015.3152461-1-radhey.shyam.pandey@amd.com>

On Mon, Sep 28, 2026, Radhey Shyam Pandey wrote:
> dwc3-xilinx does not release what it acquires: system suspend exits the
> USB3 PHY without powering it off, the ZynqMP init error paths leave the
> core resets deasserted, and neither probe failure nor remove undoes the
> reset and PHY state at all.  These three patches fix each in turn.
> 
> Changes in v3:
> The usb_resets_released flag and the pltfm_exit pointer are gone.  The
> teardown is now a devm_add_action_or_reset() action, guarded on usb3-phy
> so it only undoes the reset cycle init performed, and invoked explicitly
> before the clocks are gated on both the probe error path and remove, so
> .shutdown gets it too.
> 
> Changes in v2:
> Split out of a five patch series so the fixes can be sent and backported
> on their own, and reordered ahead of the platform-data cleanups.  Patch
> 3 was reworked so it no longer depends on that cleanup, and all three
> are tagged for stable.
> 
> All three are tagged for stable.
> Tested on ZCU102: unbind and rebind cycle cleanly with the device
> re-enumerating at SuperSpeed, and reboot is clean.
> 
> Link to v1:
> https://urldefense.com/v3/__https://lore.kernel.org/all/20260810174713.2325292-1-radhey.shyam.pandey@amd.com/__;!!A4F2R9G_pg!d4dH4RYBRKYYxRO-3MGmHJZ86UXN4JYGusxmhX4jDPLX6H5W62iLJiLacptn5Rp4xREH-Vz1JK6yyLXc6Xfuob4dk7gorw$ 
> Link to v2:
> https://urldefense.com/v3/__https://lore.kernel.org/all/20260922182125.11067-1-radhey.shyam.pandey@amd.com/__;!!A4F2R9G_pg!d4dH4RYBRKYYxRO-3MGmHJZ86UXN4JYGusxmhX4jDPLX6H5W62iLJiLacptn5Rp4xREH-Vz1JK6yyLXc6Xfuob7oSPp7Kw$ 
> 
> Radhey Shyam Pandey (3):
>   usb: dwc3: xilinx: fix system suspend and resume PHY handling
>   usb: dwc3: xilinx: re-assert resets on ZynqMP init error paths
>   usb: dwc3: xilinx: unwind ZynqMP platform init on probe failure and
>     remove
> 
>  drivers/usb/dwc3/dwc3-xilinx.c | 123 +++++++++++++++++++++++++++------
>  1 file changed, 100 insertions(+), 23 deletions(-)
> 
> 
> base-commit: abc36cbda29d8f19cf3a580cd86ca9e865186a41
> -- 
> 2.44.4
> 

I missed seeing the v3 of this series. Looking through the changes now.

Thanks,
Thinh

      parent reply	other threads:[~2026-10-02 21:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 12:00 [PATCH v3 0/3] usb: dwc3: xilinx: error path and teardown fixes Radhey Shyam Pandey
2026-09-28 12:00 ` [PATCH v3 1/3] usb: dwc3: xilinx: fix system suspend and resume PHY handling Radhey Shyam Pandey
2026-10-02 21:49   ` Thinh Nguyen
2026-09-28 12:00 ` [PATCH v3 2/3] usb: dwc3: xilinx: re-assert resets on ZynqMP init error paths Radhey Shyam Pandey
2026-10-02 21:55   ` Thinh Nguyen
2026-09-28 12:00 ` [PATCH v3 3/3] usb: dwc3: xilinx: unwind ZynqMP platform init on probe failure and remove Radhey Shyam Pandey
2026-10-02 22:07   ` Thinh Nguyen
2026-10-02 21:27 ` Thinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asAhNsmiBunddm-W@vbox \
    --to=thinh.nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=p.zabel@pengutronix.de \
    --cc=radhey.shyam.pandey@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.