All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Sang-Hoon Choi <csh0052@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	linux-nvme@lists.infradead.org, Changyul Lee <lcy8047@gmail.com>
Subject: Re: [PATCH] nvmet: use the local P2P device on metadata allocation failure
Date: Sat, 3 Oct 2026 09:57:47 +0100	[thread overview]
Message-ID: <asDDi5Fmgsh1JWEa@kbusch-mbp> (raw)
In-Reply-To: <179075213853.3.11747926147721077082.idr-bug-90@gmail.com>

On Wed, Sep 30, 2026 at 04:08:58PM +0900, Sang-Hoon Choi wrote:
> nvmet_req_alloc_p2pmem_sgls() assigns req->p2p_dev only after the data
> and metadata SGL allocations succeed. If the data allocation succeeds
> but the metadata allocation fails, out_free_sg passes req->p2p_dev to
> pci_p2pmem_free_sgl() before that assignment has taken place.
> 
> Pass the local p2p_dev argument instead, so cleanup uses the same PCI
> device as the successful data allocation.

Thanks, applied to nvme-7.3.


      parent reply	other threads:[~2026-10-03  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  7:08 [PATCH] nvmet: use the local P2P device on metadata allocation failure Sang-Hoon Choi
2026-09-30  8:05 ` Maurizio Lombardi
2026-10-03  8:57 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asDDi5Fmgsh1JWEa@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=csh0052@gmail.com \
    --cc=hch@lst.de \
    --cc=kch@nvidia.com \
    --cc=lcy8047@gmail.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.