From: Mark Brown <broonie@kernel.org>
To: michael.reeves077@gmail.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
maple-tree@lists.infradead.org, asahi@lists.linux.dev
Subject: Re: [PATCH v2 2/2] regmap: Drop map lock during cache init and exit
Date: Mon, 5 Oct 2026 14:03:10 +0200 [thread overview]
Message-ID: <asOR_mP6pc2Dy3OA@sirena.co.uk> (raw)
In-Reply-To: <20261004-regcache-lifecycle-submit-v2-2-976d405e89a7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 590 bytes --]
On Sun, Oct 04, 2026 at 11:38:43PM +1100, Michael Reeves via B4 Relay wrote:
> From: Michael Reeves <michael.reeves077@gmail.com>
>
> On systems with CONFIG_PROVE_RAW_LOCK_NESTING enabled, Apple GPIO probe
> triggers an "Invalid wait context" lockdep warning.
> - mas_lock(&mas);
> + spin_lock_irqsave(&mt->ma_lock, flags);
I think this needs at least a comment explaining why we're not using
mas_lock(), otherwise people will try to change to using mas_lock()
since there's no obvious reason we need to exclude interrupts and we're
peering inside the maple tree internals.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-10-05 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 12:38 [PATCH v2 0/2] regmap: Fix cache lifecycle locking and teardown Michael Reeves via B4 Relay
2026-10-04 12:38 ` Michael Reeves
2026-10-04 12:38 ` [PATCH v2 1/2] regmap: Remove debugfs before cache teardown Michael Reeves via B4 Relay
2026-10-04 12:38 ` Michael Reeves
2026-10-04 12:38 ` [PATCH v2 2/2] regmap: Drop map lock during cache init and exit Michael Reeves via B4 Relay
2026-10-04 12:38 ` Michael Reeves
2026-10-05 12:03 ` Mark Brown [this message]
2026-10-05 15:49 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asOR_mP6pc2Dy3OA@sirena.co.uk \
--to=broonie@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maple-tree@lists.infradead.org \
--cc=michael.reeves077@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.