From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F26A5CA5FCE for ; Mon, 5 Oct 2026 12:09:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xDhUy-0005s9-Oz; Mon, 05 Oct 2026 08:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xDhUs-0005nB-V3 for qemu-devel@nongnu.org; Mon, 05 Oct 2026 08:08:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xDhUr-0004aB-7m for qemu-devel@nongnu.org; Mon, 05 Oct 2026 08:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791202124; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kL5kNh2FZ6DP+XCeCTJ+fdbv5ux+6yG59/qGpYqWLf4=; b=PbvefKvQpJlSqC/YD+v+DAIWc4vYUmdQJ6oGIAcdQUli054Tp07DGxyjSGb8qkBfnp/Z8R ssgutwh38hy4tifCZD7K7sxYswxIx7t7ZeIR3q5wegOBgEK/JUkDPn6BAP7Zn9Psp8s/mv dcXRJm3mMascOgFf1Q20nB5J1hPUNPM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-cEPaxYxlNTymyL0Wb5iloQ-1; Mon, 05 Oct 2026 08:08:42 -0400 X-MC-Unique: cEPaxYxlNTymyL0Wb5iloQ-1 X-Mimecast-MFC-AGG-ID: cEPaxYxlNTymyL0Wb5iloQ_1791202121 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CFE2193E8F1 for ; Mon, 5 Oct 2026 12:08:41 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F38C5180057F; Mon, 5 Oct 2026 12:08:39 +0000 (UTC) Date: Mon, 5 Oct 2026 13:08:37 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel , Stefan Hajnoczi Subject: Re: [PATCH 16/20] trace: include qemu_loglevel_mask(LOG_TRACE) in guard Message-ID: References: <20261001151228.3373747-1-berrange@redhat.com> <20261001151228.3373747-17-berrange@redhat.com> <75ae2444-0ac9-4aee-8881-fb3431c639e8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.4.2 (2026-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 02, 2026 at 04:49:19PM +0200, Paolo Bonzini wrote: > Il ven 2 ott 2026, 13:04 Daniel P. Berrangé ha > scritto: > > > On Fri, Oct 02, 2026 at 12:45:49PM +0200, Paolo Bonzini wrote: > > > On 10/1/26 17:12, Daniel P. Berrangé wrote: > > > > If emitting a trace event requires computation for the parameters > > > > passed to the probe, the callers should guard that computation > > > > with trace_event_by_state_backends(), which is a macro expanding > > > > to the a check of the "TRACE_...._DSTATE()" expression. For the > > > > log backend this should include a check for LOG_TRACE being > > > > present in the configured log level. > > > This also needs something for Rust (apologies for the mailer damage): > > > > Ok, I'll test that and include it in a future v3, since I already > > sent out v2 before seeing this. > > > > No hurry, it's just an optimization. Trying your suggested patch exposed an existing bug in the code, where we did not merge the checks in the C code, and this was only apparent once removing the CHECK_TRACE_EVENT_GET_STATE flag. So I've fixed this all in the v3 posting. > > Paolo > > > --- a/scripts/tracetool/backend/log.py > > > +++ b/scripts/tracetool/backend/log.py > > > @@ -16,7 +16,6 @@ > > > > > > > > > PUBLIC = True > > > -CHECK_TRACE_EVENT_GET_STATE = True > > > > > > > > > def generate_h_begin(events, group): > > > @@ -52,3 +51,9 @@ def generate_rs(event, group): > > > ' }', > > > fmt=expand_format_string(event.fmt, event.name + " "), > > > args=event.args.rust_call_varargs()) > > > + > > > +def generate_rs_backend_dstate(event, group): > > > + out(' unsafe { (bindings::qemu_loglevel & bindings::LOG_TRACE) > > != 0 > > > && ' > > > + + 'trace_event_state_is_enabled(_%(event_id)s_DSTATE) } ||', > > > + event_id = 'TRACE_' + e.name.upper()) > > > + > > > > > > Paolo > > > > > > > With regards, > > Daniel > > -- > > |: https://berrange.com ~~ https://hachyderm.io/@berrange :| > > |: https://libvirt.org ~~ https://entangle-photo.org :| > > |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| > > > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|