From: Eric Blake <eblake@redhat.com>
To: Guillaume Vincke <guillaume.vincke@ovhcloud.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH 2/2] iotests: Add coverage for NBD connect thread start delay
Date: Mon, 5 Oct 2026 14:29:50 -0500 [thread overview]
Message-ID: <asP6i-iViGlBTmN2@redhat.com> (raw)
In-Reply-To: <asPv5A2Ie02ruyy3@redhat.com>
On Mon, Oct 05, 2026 at 01:44:10PM -0500, Eric Blake wrote:
> On Fri, Sep 25, 2026 at 05:53:46PM +0200, Guillaume Vincke wrote:
> > Test the connect thread starting condition with reconnect-delay=0 when
> > the server disconnects after a successful handshake but before running
> > operations. Prior to the change to nbd_co_establish_connection(), this
> > test would demonstrate two I/O errors. The tests 264 and 277 covering
> > reconnection do not use reconnect-delay=0 so this case is not exercised.
> >
> > Add a test that provokes multiple errors in order to put an NBD client
> > in the above-mentioned situation and shows that the first operation
> > starts the connect thread and leads to successful subsequent I/O.
> >
> > Signed-off-by: Guillaume Vincke <guillaume.vincke@ovhcloud.com>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Also, I checked that this new test exposes the problem if applied
independently from the patch in 1/2.
Tested-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
prev parent reply other threads:[~2026-10-05 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 15:53 [PATCH 0/2] nbd/client-connection: Fix client returning a closed channel Guillaume Vincke
2026-09-25 15:53 ` [PATCH 1/2] " Guillaume Vincke
2026-09-25 21:00 ` Eric Blake
2026-09-28 8:23 ` guillaume vincke
2026-10-06 19:13 ` Eric Blake
2026-10-07 12:47 ` guillaume vincke
2026-09-25 15:53 ` [PATCH 2/2] iotests: Add coverage for NBD connect thread start delay Guillaume Vincke
2026-10-05 18:44 ` Eric Blake
2026-10-05 19:29 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asP6i-iViGlBTmN2@redhat.com \
--to=eblake@redhat.com \
--cc=guillaume.vincke@ovhcloud.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.