From: Benjamin Marzinski <bmarzins@redhat.com>
To: Suresh Thelkar <suresh.thelkar@yahoo.com>
Cc: dm-devel@lists.linux.dev, Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH 1/2] libmultipath: dm_flush_map__: do not treat query error as external removal
Date: Mon, 5 Oct 2026 13:33:53 -0400 [thread overview]
Message-ID: <asPfgTUiqKK0IFiI@redhat.com> (raw)
In-Reply-To: <20261005045726.71858-2-suresh.thelkar@yahoo.com>
On Mon, Oct 05, 2026 at 04:57:25AM +0000, Suresh Thelkar wrote:
> On a failed DM_DEVICE_REMOVE, dm_flush_map__() classified anything that
> was not DM_IS_MPATH_YES as "removed externally" and returned DM_FLUSH_OK
> without resuming the map it had just suspended. dm_is_mpath() also
> returns DM_IS_MPATH_ERR (-1) when the status query itself fails, which
> happens transiently under a heavy ioctl load (e.g. LUN-number recycling
> plus ALUA transitions). A transient error was thus misread as a
> successful external removal, and the map was left suspended
> indefinitely, wedging later I/O node-wide via sync().
>
> Only DM_IS_MPATH_NO now counts as "removed externally". A query error is
> logged and falls through to the resume path instead of being reported as
> success.
>
> Signed-off-by: Suresh Thelkar <suresh.thelkar@yahoo.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
next prev parent reply other threads:[~2026-10-05 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261005045726.71858-1-suresh.thelkar.ref@yahoo.com>
2026-10-05 4:57 ` [PATCH 0/2] libmultipath: fix leaked device-mapper suspend after a failed remove Suresh Thelkar
2026-10-05 4:57 ` [PATCH 1/2] libmultipath: dm_flush_map__: do not treat query error as external removal Suresh Thelkar
2026-10-05 17:33 ` Benjamin Marzinski [this message]
2026-10-05 4:57 ` [PATCH 2/2] libmultipath: dm_flush_map__: retry the resume after a failed remove Suresh Thelkar
2026-10-05 17:59 ` Benjamin Marzinski
2026-10-06 21:07 ` Martin Wilck
2026-10-07 7:16 ` Suresh Thelkar
2026-10-07 7:22 ` Martin Wilck
2026-10-07 9:09 ` Suresh Thelkar
2026-10-07 9:22 ` [PATCH v2 0/2] libmultipath: fix leaked device-mapper suspend " Suresh Thelkar
2026-10-07 9:22 ` [PATCH v2 1/2] libmultipath: dm_flush_map__: do not treat query error as external removal Suresh Thelkar
2026-10-07 9:22 ` [PATCH v2 2/2] libmultipath: dm_flush_map__: log if the resume fails after a failed remove Suresh Thelkar
2026-10-07 16:42 ` Benjamin Marzinski
2026-10-07 19:21 ` Martin Wilck
2026-10-08 4:36 ` Suresh Thelkar
2026-10-08 4:37 ` [PATCH v3 0/2] libmultipath: fix leaked device-mapper suspend " Suresh Thelkar
2026-10-08 4:37 ` [PATCH v3 1/2] libmultipath: dm_flush_map__: do not treat query error as external removal Suresh Thelkar
2026-10-08 4:37 ` [PATCH v3 2/2] libmultipath: dm_flush_map__: retry the resume after a failed remove Suresh Thelkar
2026-10-08 11:25 ` [PATCH v3 0/2] libmultipath: fix leaked device-mapper suspend " mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asPfgTUiqKK0IFiI@redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=mwilck@suse.com \
--cc=suresh.thelkar@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.