Re: [PATCH 08/13] qemu-io: accept --object iothread

[Eric Blake <eblake@redhat.com>]

On Wed, Sep 30, 2026 at 06:49:54PM +0200, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
> 
> qemu-io refused "--object iothread,id=t0" with "invalid object type:
> iothread", because iothread.c was built into blockdev_ss, which qemu-io
> does not link. Move it to block_ss: it wraps an AioContext and has
> nothing to do with blockdev, and linking blockdev instead would drag in
> os-posix.c, whose qemu_system_killed() every program linking it has to
> define.
> 
> Collect the --object arguments during option parsing and process them
> once qemu_init_main_loop() has run; nothing before that point uses an
> object. An iothread created earlier registers the timer lists of its
> AioContext with clocks that qemu_init_clocks() then resets, unlinking
> them silently: no failure, just timers that never fire.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Hanna Reitz <hreitz@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> CC: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
>  meson.build | 2 +-
>  qemu-io.c   | 9 ++++++++-
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org