All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin/repo: rename "references.format" to "references.storageFormat"
Date: Tue, 6 Oct 2026 07:53:27 +0200	[thread overview]
Message-ID: <asSM12B35oka08Nu@pks.im> (raw)
In-Reply-To: <CAOLa=ZTNNY_XuixqZ96TK0zFfDpWvxSupxVGOnH1VGXK4KF_0w@mail.gmail.com>

On Mon, Oct 05, 2026 at 03:11:19PM +0000, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > As part of 2f28db44d5 (Merge branch 'ps/ref-storage-format', 2026-10-01)
> > we have adapt all sites that used to say "reference format" to instead
> > say "reference storage format".
> >
> > One missed spot though was in git-repo(1), where we still print the
> > "references.format" key. Fix that oversight by renaming the key to
> > "references.storageFormat".
> 
> The patch looks good, but this does break backward compatibility. But
> since the command it marked as experimental, this should be okay.

Right, I should've probably mentioned this as part of the commit
message. We could for a while carry both keys of course. But given that
it's marked as experimental I think it's okay to break the format and
drop the old key.

Thanks!

Patrick

  reply	other threads:[~2026-10-06  5:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 10:14 [PATCH] builtin/repo: rename "references.format" to "references.storageFormat" Patrick Steinhardt
2026-10-05 15:11 ` Karthik Nayak
2026-10-06  5:53   ` Patrick Steinhardt [this message]
2026-10-06 11:57     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asSM12B35oka08Nu@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.