Re: [PATCH v1 6/7] perf symbol: Set binary type for JIT map DSOs

[Namhyung Kim <namhyung@kernel.org>]

On Mon, Oct 05, 2026 at 06:46:16AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] perf: annotate regression on JIT map files due to unhandled binary type
> --
> 
> commit 79781ef5615895fe2ec492b108f82094b6a0246b
> Author: Namhyung Kim <namhyung@kernel.org>
> 
> perf symbol: Set binary type for JIT map DSOs
> 
> This commit explicitly sets the binary type of JIT map DSOs to JAVA_JIT. This
> ensures they are identified correctly and bypass attempts to load dso_data, 
> as they only contain symbol names and lack binary instructions.
> 
> > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -1859,6 +1859,7 @@ int dso__load(struct dso *dso, struct map *map)
> >  
> >  	if (perfmap) {
> >  		ret = dso__load_perf_map(map_path, dso);
> > +		dso__set_binary_type(dso, DSO_BINARY_TYPE__JAVA_JIT);
> 
> [Severity: Medium]
> Does setting the binary type to DSO_BINARY_TYPE__JAVA_JIT here bypass the
> historical early exit guard in symbol__disassemble()?
> 
> Looking at symbol__disassemble() in tools/perf/util/disasm.c, it guards
> against unsupported files with:
> 
>     if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND) {
>         return SYMBOL_ANNOTATE_ERRNO__COULDNT_DETERMINE_FILE_TYPE;
>     }
> 
> With the type now explicitly set to DSO_BINARY_TYPE__JAVA_JIT, this check
> fails and allows perf annotate to incorrectly attempt disassembling the text
> map file. 
> 
> The fallback binary disassemblers inevitably fail to parse the text file as
> ELF and return -1. This propagates back to symbol__strerror_disassemble(),
> which handles the -1 return by printing an unhelpful message to the user
> instead of gracefully exiting:
> 
>     default:
>         scnprintf(buf, buflen, "Internal error: Invalid %d error code\n", errnum);
>         break;
> 
> Should symbol__disassemble() be updated to check for DSO_BINARY_TYPE__JAVA_JIT
> so that it can exit gracefully when users try to annotate a JIT symbol profile?

Ok, but I think the dso__disassemble_filename() should be updated to set
binary type correctly and just use dso__get_filename().  Will do in v2.

Thanks,
Namhyung