All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: James Fairweather <james.a.fairweather@gmail.com>
Cc: "Łukasz Bartosik" <ukaszb@chromium.org>,
	"Andrei Kuchynski" <akuchynski@chromium.org>,
	"Jameson Thies" <jthies@google.com>,
	"Benson Leung" <bleung@chromium.org>,
	chrome-platform@lists.linux.dev,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004
Date: Tue, 6 Oct 2026 10:28:10 +0000	[thread overview]
Message-ID: <asTNOr4A_dD5Kiq9@google.com> (raw)
In-Reply-To: <20261003222855.23707-1-james.a.fairweather@gmail.com>

On Sat, Oct 03, 2026 at 06:28:53PM -0400, James Fairweather wrote:
> cros_usbpd_notify_probe_acpi() takes the EC device pointer from
> dev_get_drvdata(dev->parent) and assumes it is a struct cros_ec_device.
> That only holds when GOOG0003 is a child of GOOG0004. On older devices
> without that hierarchy, such as Google Nami, GOOG0003 and GOOG0004 are
> siblings under the ACPI EC (PNP0C09):
> 
>   PNP0C09:00 (acpi-ec)
>   |-- GOOG0003:00 (cros-usbpd-notify-acpi)
>   `-- GOOG0004:00 (cros_ec_lpcs)
> 
> [...]

Applied to

    https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next

[1/1] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004
      commit: ca75b38b1a3c2eabe81d231dae4ea180cf6287cd

Thanks!

  parent reply	other threads:[~2026-10-06 10:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 22:28 [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004 James Fairweather
2026-10-05  3:41 ` Tzung-Bi Shih
2026-10-06  7:14 ` Sergey Tiraspolsky
2026-10-06 10:28 ` Tzung-Bi Shih [this message]
2026-10-08  8:43 ` wendler.david

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asTNOr4A_dD5Kiq9@google.com \
    --to=tzungbi@kernel.org \
    --cc=akuchynski@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=james.a.fairweather@gmail.com \
    --cc=jthies@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=ukaszb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.