Re: [PATCH v2] qga: implement 'guest-get-diskstats' for FreeBSD

[Roman Bogorodskiy <bogorodskiy@gmail.com>]

  Kostiantyn Kostiuk wrote:

> Reviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> 
> On Tue, Sep 1, 2026 at 10:29 PM Roman Bogorodskiy <bogorodskiy@gmail.com>
> wrote:
> 
> > Implement the 'guest-get-diskstats' for FreeBSD.
> > This implementation uses the devstat(3) library which is a part
> > of the FreeBSD base system.
> >
> > The build system is updated to link qga with `-ldevstat`.
> >
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
> > Acked-by: Markus Armbruster <armbru@redhat.com> (QAPI schema)
> > ---
> > Changes since v1:
> >  - Replace the guest_diskstats_append() helper with a simpler
> > guest_diskstats_info_new().
> >  - Drop the unnecessary condition for ios_pgr.
> >  - Drop the unnecessary guest_get_diskstats() wrapper.
> >  - Jump to error on devstat_getdevs() as it does allocations.
> >
> >  qga/commands-bsd.c   | 120 +++++++++++++++++++++++++++++++++++++++++++
> >  qga/meson.build      |   3 ++
> >  qga/qapi-schema.json |   6 +--
> >  3 files changed, 126 insertions(+), 3 deletions(-)

Hi,

Is there anything else needed from my side before this can be merged?

Thanks,
Roman