All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nico Williams <nico@cryptonector.com>
To: phillip.wood@dunelm.org.uk
Cc: Alejandro Colomar <alx@kernel.org>,
	Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: Re: git-rebase-walk
Date: Tue, 6 Oct 2026 09:58:24 -0500	[thread overview]
Message-ID: <asUMkBi9NG0k6fu4@ubby> (raw)
In-Reply-To: <792f4d41-bd60-4fae-a426-bd70cbad996c@gmail.com>

On Tue, Oct 06, 2026 at 03:01:29PM +0100, Phillip Wood wrote:
> On 05/10/2026 14:37, Alejandro Colomar wrote:
> > > Below is a shell session performing such a rebase, which hopefully shows
> > > why I need this to be multi-shot.
> 
> To me it shows that we need to improve "git rebase --update-refs" so that it
> can rebase a tree of branches automatically. Doing it manually is labor
> intensive and error-prone (your example output shows it is easy to forget
> when you're meant to be resolving a conflict instead aborting the rebase and
> checking out another branch). In the example below
> 
>     git rebase --update-refs --rebase-merges main B
> 
> will rebase A and B, but we don't have a way of including C.

But it's not the same problem.  This isn't about rebasing a set of
stacked branches all at once.  This is about rebasing quickly across
thousands of upstream commits.

Naturally one _could_ use `--update-refs` with a bisect-rebase.  The two
features are orthogonal.

I've been using this bisect-rebase script to rebase an old branch off PG
to the latest upstream -- that's 10,135 commits in my case(!).

> > > On the simpler case of a single branch, I'd still prefer a multi-shot
> > > approach where --continue only advances one rebase operation, because at
> > > the end of it I want to stop, and check git-range-diff(1) to make sure
> > > it all makes sense.
> 
> Perhaps we could insert "break" commands after each branch is rebased so the
> user can check the range-diff.

The bisect-rebase scripts do stop when a conflict is found that the user
should resolve.  The noise from the bisection's search for that
appropriate commit is not that interesting except as a sort of progress
meter.  Stopping at each point in the bisection where the bisection
would continue is not going to be that useful unless the user could
check if the conflicts are simple and obvious enough at each point and
skip the rest of the bisection -- is that your idea?  But if so then the
bisection will be very painful if the user would mostly elect to
continue it.  That could be an option -- if it works, great, and if not
start over without that option.

Nico
-- 

  reply	other threads:[~2026-10-06 16:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 11:58 git-rebase-walk Alejandro Colomar
2026-10-01 13:22 ` git-rebase-walk Patrick Steinhardt
2026-10-01 15:51   ` git-rebase-walk Alejandro Colomar
2026-10-02  6:46     ` git-rebase-walk Patrick Steinhardt
2026-10-02  7:19       ` git-rebase-walk Alejandro Colomar
2026-10-03 19:37         ` git-rebase-walk Nico Williams
2026-10-04 10:03       ` git-rebase-walk Phillip Wood
2026-10-05 13:28         ` git-rebase-walk Alejandro Colomar
2026-10-05 13:37           ` git-rebase-walk Alejandro Colomar
2026-10-06 14:01             ` git-rebase-walk Phillip Wood
2026-10-06 14:58               ` Nico Williams [this message]
2026-10-06 16:45                 ` git-rebase-walk Alejandro Colomar
2026-10-08 22:05               ` git-rebase-walk Alejandro Colomar
2026-10-08 22:07                 ` git-rebase-walk Alejandro Colomar
2026-10-01 17:31   ` git-rebase-walk Junio C Hamano
2026-10-01 16:10 ` git-rebase-walk Nico Williams
2026-10-01 16:50   ` git-rebase-walk Alejandro Colomar
2026-10-01 17:40     ` git-rebase-walk Nico Williams
2026-10-01 20:29       ` git-rebase-walk Alejandro Colomar
2026-10-01 21:01         ` git-rebase-walk Nico Williams
2026-10-01 21:35           ` git-rebase-walk Nico Williams
2026-10-02  2:49 ` git-rebase-walk Simon Richter
2026-10-02  3:19   ` git-rebase-walk Nico Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asUMkBi9NG0k6fu4@ubby \
    --to=nico@cryptonector.com \
    --cc=alx@kernel.org \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.