All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Arges <carges@cloudflare.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: David Ahern <dsahern@kernel.org>,
	Ido Schimmel <idosch@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 0/6] ip: Batch flushing uncached routes per batched device unregistration.
Date: Tue, 6 Oct 2026 15:07:18 -0500	[thread overview]
Message-ID: <asVU9o8eZkMz5zsN@20HS2G4> (raw)
In-Reply-To: <20261001204752.2572265-1-kuniyu@google.com>

On 2026-10-01 20:47:12, Kuniyuki Iwashima wrote:
> Chris J Arges reported high RTNL contention during cleanup_net()
> caused by rt_flush_dev() and rt6_uncached_list_flush_dev() iterating
> over the global per-cpu uncached route lists for every netdev in
> dying netns [0].
> 
> This series resolves the issue by batching the uncached route
> cleanup after __rtnl_unlock() in netdev_run_todo()
> 
> [0]: https://lore.kernel.org/netdev/20260917-hash-bucket-route-lists-v3-0-30493a37b6eb@cloudflare.com/
> 
> 
> Changelog:
>   v3:
>     * Add patch 1 ~ 4
>     * Patch 6
>       * Unlink routes only when both devices are blackhole_netdev
>       * Clarify netdev_run_todo() does not run before
>         rt6_uncached_list is initialised
>       * Fix CONFIG_IPV6=n build
> 
>   v2: https://lore.kernel.org/netdev/20260929201546.1533268-1-kuniyu@google.com/
>     * Drop ->pre_exit_batch()
>     * Do batching after setting NETDEV_UNREGISTERED in netdev_run_todo()
> 
>   v1: https://lore.kernel.org/netdev/20260927202429.2452589-1-kuniyu@google.com/
> 
> 
> Kuniyuki Iwashima (6):
>   net: Order blackhole_netdev_init(), inet_init(), and inet6_init().
>   ipv4: Inline inet_blackhole_dev_init() to devinet_init().
>   net: Rename dev_isalive() to netif_is_alive().
>   xfrm: Check netif_is_alive() in xfrm_bundle_create() and
>     xfrm_create_dummy_bundle().
>   ipv4: Batch rt_flush_dev() in netdev_run_todo().
>   ipv6: Batch rt6_uncached_list_flush_dev() in netdev_run_todo().
> 
>  drivers/net/loopback.c    |  2 +-
>  include/linux/netdevice.h |  6 ++++++
>  include/net/ip6_route.h   |  7 +++++++
>  include/net/route.h       |  6 ++++++
>  net/core/dev.c            |  7 +++++++
>  net/core/dev.h            |  6 ------
>  net/core/net-sysfs.c      | 16 ++++++++--------
>  net/core/netdev_work.c    |  4 ++--
>  net/core/rtnetlink.c      |  2 +-
>  net/ipv4/devinet.c        | 17 +++++------------
>  net/ipv4/route.c          | 11 +++++++++--
>  net/ipv6/af_inet6.c       |  2 +-
>  net/ipv6/route.c          | 24 ++++++++++++++++--------
>  net/xfrm/xfrm_policy.c    |  4 ++--
>  14 files changed, 71 insertions(+), 43 deletions(-)
> 
> -- 
> 2.56.0.rc1.315.gc6ed9934b7-goog
>

I was able to run the v3 patchset locally and confirm it addresses
the original issue.

Tested-By: Chris J Arges <carges@cloudflare.com>

--chris

  parent reply	other threads:[~2026-10-06 20:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 20:47 [PATCH v3 net-next 0/6] ip: Batch flushing uncached routes per batched device unregistration Kuniyuki Iwashima
2026-10-01 20:47 ` [PATCH v3 net-next 1/6] net: Order blackhole_netdev_init(), inet_init(), and inet6_init() Kuniyuki Iwashima
2026-10-05 12:18   ` Fernando Fernandez Mancera
2026-10-01 20:47 ` [PATCH v3 net-next 2/6] ipv4: Inline inet_blackhole_dev_init() to devinet_init() Kuniyuki Iwashima
2026-10-04 23:02   ` netdev-bot+sashiko
2026-10-01 20:47 ` [PATCH v3 net-next 3/6] net: Rename dev_isalive() to netif_is_alive() Kuniyuki Iwashima
2026-10-01 20:47 ` [PATCH v3 net-next 4/6] xfrm: Check netif_is_alive() in xfrm_bundle_create() and xfrm_create_dummy_bundle() Kuniyuki Iwashima
2026-10-01 20:47 ` [PATCH v3 net-next 5/6] ipv4: Batch rt_flush_dev() in netdev_run_todo() Kuniyuki Iwashima
2026-10-04 23:02   ` netdev-bot+sashiko
2026-10-05  0:51     ` Kuniyuki Iwashima
2026-10-01 20:47 ` [PATCH v3 net-next 6/6] ipv6: Batch rt6_uncached_list_flush_dev() " Kuniyuki Iwashima
2026-10-04 23:02   ` netdev-bot+sashiko
2026-10-05  0:49     ` Kuniyuki Iwashima
2026-10-06  8:12 ` [PATCH v3 net-next 0/6] ip: Batch flushing uncached routes per batched device unregistration Ido Schimmel
2026-10-06 17:45   ` Kuniyuki Iwashima
2026-10-06 20:07 ` Chris Arges [this message]
2026-10-06 23:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asVU9o8eZkMz5zsN@20HS2G4 \
    --to=carges@cloudflare.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.