From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F4237CA5FFF for ; Wed, 7 Oct 2026 08:56:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xENBA-0007tM-Ea; Wed, 07 Oct 2026 04:39:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xEISY-000433-F3 for qemu-devel@nongnu.org; Tue, 06 Oct 2026 23:36:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xEISK-0008To-Mm for qemu-devel@nongnu.org; Tue, 06 Oct 2026 23:36:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791344163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=epOPjtpfhjcgXLEVRyDwO9+wTuqrvXxMWECrCalhg64=; b=agDfg6uejhqq15IuOqviXeU9wgk0q3RstHwIMN6aahHRZQ5ruRmKGW8RGOOlNYPslvOvn3 sdhrz+x5CywZIV5yTSbtIbkgKuD+bYBjhzBE+LrisgP+EczI1rWQyF0q8CH3cVsfjOZZmX qCmc9zkMHwlAUCuXZ8FaG/+bf3sZGUA= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-__VhWUPcNXCYw0lDl92RAQ-1; Tue, 06 Oct 2026 17:33:55 -0400 X-MC-Unique: __VhWUPcNXCYw0lDl92RAQ-1 X-Mimecast-MFC-AGG-ID: __VhWUPcNXCYw0lDl92RAQ_1791322434 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 29DD71805A11; Tue, 6 Oct 2026 21:33:53 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 099C1180034F; Tue, 6 Oct 2026 21:33:49 +0000 (UTC) Date: Tue, 6 Oct 2026 16:33:46 -0500 From: Eric Blake To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Peter Xu , Fabiano Rosas , Vladimir Sementsov-Ogievskiy , qemu-stable@nongnu.org Subject: Re: [PATCH v2 1/3] migration: add QEMU_COUNTED_STRING_SIZE for counted string buffers Message-ID: References: <20261006170738.453977-1-den@openvz.org> <20261006170738.453977-2-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006170738.453977-2-den@openvz.org> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 06, 2026 at 07:07:36PM +0200, Denis V. Lunev wrote: > From: Denis V. Lunev > > A counted string carries its length in one byte, so the buffer that > qemu_get_counted_string() fills must hold 256 bytes. The dirty bitmap > load state spells that size as a bare 256 for both of its alias buffers. > Name it next to the qemu_get_counted_string() prototype and use it there, > in the length assert of qemu_put_counted_string() and in DBMLoadState. > > Suggested-by: Eric Blake > Signed-off-by: Denis V. Lunev > Cc: Peter Xu > Cc: Fabiano Rosas > Cc: Eric Blake > Cc: Vladimir Sementsov-Ogievskiy > Cc: qemu-stable@nongnu.org > --- > include/migration/qemu-file-types.h | 6 +++++- > migration/block-dirty-bitmap.c | 4 ++-- > migration/qemu-file.c | 5 +++-- > 3 files changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org