All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] meson.build: export TARGET_ARCH_VARIANT in target config
Date: Wed, 7 Oct 2026 08:09:40 +0100	[thread overview]
Message-ID: <asXwNOIm6DFzcoZD@redhat.com> (raw)
In-Reply-To: <20261006182558.151956-2-pierrick.bouvier@oss.qualcomm.com>

On Tue, Oct 06, 2026 at 06:25:57PM +0000, Pierrick Bouvier wrote:
> For now, TARGET_ARCH only contains 32 vs 64 bit arch. The variants,
> based on endianness, are accessible through TARGET_NAME. However,
> TARGET_NAME is a string, and thus can't be concatenated to generate code
> and retrieve matching SYS_EMU_TARGET enum entry.
> Thus, export this information in TARGET_ARCH_VARIANT as an unquoted
> identifier.
> 
> There is one more subtlety, user binaries have extra targets that are
> not present in SYS_EMU_TARGET, like armeb.
> Thus, for user binaries, simply export TARGET_ARCH.
> 
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> ---
>  meson.build | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  parent reply	other threads:[~2026-10-07  9:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 18:25 [PATCH 0/2] target-info: expose full target variant Pierrick Bouvier
2026-10-06 18:25 ` [PATCH 1/2] meson.build: export TARGET_ARCH_VARIANT in target config Pierrick Bouvier
2026-10-07  5:21   ` Philippe Mathieu-Daudé
2026-10-07  7:09   ` Daniel P. Berrangé [this message]
2026-10-07  7:48   ` Yonggang Luo
2026-10-07 14:28     ` Pierrick Bouvier
2026-10-07 14:47       ` Yonggang Luo
2026-10-07 16:09         ` Pierrick Bouvier
2026-10-07 14:52       ` Daniel P. Berrangé
2026-10-07  9:27   ` Yonggang Luo
2026-10-07 14:32     ` Pierrick Bouvier
2026-10-06 18:25 ` [PATCH 2/2] target-info: use TARGET_ARCH_VARIANT Pierrick Bouvier
2026-10-07  5:21   ` Philippe Mathieu-Daudé
2026-10-07  7:10   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asXwNOIm6DFzcoZD@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.