From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12420CA5FFC for ; Wed, 7 Oct 2026 12:24:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xEQg7-0003Zn-O5; Wed, 07 Oct 2026 08:23:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xEQfb-0003Wm-CT for qemu-devel@nongnu.org; Wed, 07 Oct 2026 08:22:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xEQfX-0003TY-VU for qemu-devel@nongnu.org; Wed, 07 Oct 2026 08:22:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791375766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9x1v/lLY7mbVQchBYYQXpfk0wmmiZKD/GMJOtyorAkY=; b=B0MRl55zNhvv0gU7srOPEmy0h7i9e2l/bdgYYWF2mMTKTBmRYOSsBx/c3XKg8+FaWiRfqy bkbv3ZOdhY1VtCreLSKPduL1Xh15xfNEtwMVjZRgUMpIy/P5vko7S4oseJJ6H8eq/EcQqV /WjkECjMkd9kkFnrRpGoFtS0PDvh8jA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-sxbeTqhYMsGl0mgfz-Ugjg-1; Wed, 07 Oct 2026 08:22:43 -0400 X-MC-Unique: sxbeTqhYMsGl0mgfz-Ugjg-1 X-Mimecast-MFC-AGG-ID: sxbeTqhYMsGl0mgfz-Ugjg_1791375762 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE8D219331B9; Wed, 7 Oct 2026 12:22:41 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CD7D766; Wed, 7 Oct 2026 12:22:37 +0000 (UTC) Date: Wed, 7 Oct 2026 07:22:31 -0500 From: Eric Blake To: "Denis V. Lunev" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Peter Xu , Fabiano Rosas , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v2 0/3] migration/block-dirty-bitmap: fix postcopy abort with bitmaps on several nodes Message-ID: References: <20261006170738.453977-1-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006170738.453977-1-den@openvz.org> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 06, 2026 at 07:07:35PM +0200, Denis V. Lunev wrote: > Postcopy migration of dirty bitmaps kills the destination as soon as > bitmaps live on more than one node: > > qemu-system-x86_64: ../block.c:6400: bdrv_lookup_bs: Assertion > `qemu_in_main_thread()' failed. > > Changes in v2: > - new patch 1: add QEMU_COUNTED_STRING_SIZE instead of bare 256 (Eric) > - patch 2: drop the "Error: " prefix from the new error message (Eric) > - patch 2: move node_alias to the end of LoadBitmapState > - patch 3: add Eric's Tested-by and Reviewed-by I'm queueing this series through my NBD tree, and running tests now in preparation for a pull request. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org