From: Yao Zi <me@ziyao.cc>
To: khaliforce <kforce@gmail.com>, u-boot@lists.u-boot-project.org
Cc: Samuel Holland <samuel@sholland.org>,
Tom Rini <trini@konsulko.com>, Yao Zi <me@ziyao.cc>
Subject: Re: [PATCH] serial: ns16550: make probe clock enabling optional
Date: Wed, 7 Oct 2026 09:40:51 +0000 [thread overview]
Message-ID: <asYTozF_pL1xVHfr@pie> (raw)
In-Reply-To: <179128521949.5.18128894373298117517.uboot-uart@gmail.com>
On Tue, Oct 06, 2026 at 08:14:01PM +0900, khaliforce wrote:
> From: Samuel Holland <samuel@sholland.org>
>
> Some platforms need the UART clock gates enabled before NS16550
> register access. This is required by the downstream Allwinner D1
> port used on the MangoPi MQ Pro.
>
> Add CONFIG_NS16550_CLK_ENABLE to enable the UART clocks during
> probe when explicitly selected by a platform. The option defaults
> to disabled, preserving the existing behavior on other platforms.
>
> The clock-enabling code originates from Samuel Holland's D1 work.
> This patch makes that behavior optional through Kconfig.
I think the appropriate way to model this is introducing
devicetree-compatible-specific behaviors.
> Link: https://github.com/smaeul/u-boot/commit/0617377a2555031f02a459b3451fa33ce53e9b74
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> Co-developed-by: khaliforce <kforce@gmail.com>
> Signed-off-by: khaliforce <kforce@gmail.com>
> ---
Best regards,
Yao Zi
next prev parent reply other threads:[~2026-10-07 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 11:14 [PATCH] serial: ns16550: make probe clock enabling optional khaliforce
2026-10-07 9:40 ` Yao Zi [this message]
2026-10-07 10:25 ` [PATCH v2] serial: ns16550: enable clocks for DesignWare UARTs khaliforce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asYTozF_pL1xVHfr@pie \
--to=me@ziyao.cc \
--cc=kforce@gmail.com \
--cc=samuel@sholland.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.