From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC4ABCA5FF1 for ; Wed, 7 Oct 2026 12:55:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xERAz-0002t7-PY; Wed, 07 Oct 2026 08:55:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xERAx-0002my-Cj for qemu-devel@nongnu.org; Wed, 07 Oct 2026 08:55:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xERAv-00074t-Vo for qemu-devel@nongnu.org; Wed, 07 Oct 2026 08:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791377713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JacguGrhmcBoIbd9cDPyme4mgYYLMJNl4N1CQksugQc=; b=S2wF0bY3+9z2W8TIhJ2EgcF61pMKBxjPR158mJYgzgFq/hIZKCc59xsBrBy/OPGdLsTpIK i6qyvflPZAcE9lfduZFsf3R1/SmHHY7rny+TuN7laXgtq00/hyha1F7Kq6L2Bj7r+nOXhg W2dJFCeUc29MiylK82dW1DNHxWYVXSk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-9nJLCIVHPLKLnVE7YVnCcg-1; Wed, 07 Oct 2026 08:55:07 -0400 X-MC-Unique: 9nJLCIVHPLKLnVE7YVnCcg-1 X-Mimecast-MFC-AGG-ID: 9nJLCIVHPLKLnVE7YVnCcg_1791377706 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 221A4196C42F; Wed, 7 Oct 2026 12:55:06 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC4F1426; Wed, 7 Oct 2026 12:55:00 +0000 (UTC) Date: Wed, 7 Oct 2026 07:54:56 -0500 From: Eric Blake To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Markus Armbruster , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , Pierrick Bouvier , Alexandre Iooss Subject: Re: [PATCH v2 09/11] qemu-option: Change qemu_opts_parse_noisily() to take the group Message-ID: References: <20260930221105.2262063-1-farosas@suse.de> <20260930221105.2262063-10-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260930221105.2262063-10-farosas@suse.de> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Sep 30, 2026 at 07:11:03PM -0300, Fabiano Rosas wrote: > Pass the group name as argument to qemu_opts_parse_noisily() to make > it simmetric with qemu_opts_parse(). symmetric > > This change solves the issue of qemu_opts_parse_noisily() crashing on > a NULL return from qemu_find_opts(), which can happen when an option > is invoked for code in a module that is not loaded. > -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org