From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 04/12] xfs: don't pass iget failures up when marking ondisk inodes
Date: Wed, 7 Oct 2026 06:03:59 -0700 [thread overview]
Message-ID: <asZDP2aQ4QUvxWKW@infradead.org> (raw)
In-Reply-To: <179117965094.614350.8297165772601670682.stgit@frogsfrogsfrogs>
On Sun, Oct 04, 2026 at 10:56:20PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM observes a couple of problems with this callsite -- an ENOMEM
> return is completely ignored and a subsequent run through the loop body
> obliterates the return value completely. Also, an error value
> indicating that the list is corrupt can get passed up (thus terminating
> the repair) even though we can handle corrupt lists. Fix the callsite
> not to have these problems.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-10-07 13:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 5:55 [PATCHSET] xfs: LLM-inspired bug fixes, part 20 Darrick J. Wong
2026-10-05 5:55 ` [PATCH 01/12] xfs: flag excessive delalloc rt extents as corruption Darrick J. Wong
2026-10-07 13:03 ` Christoph Hellwig
2026-10-05 5:55 ` [PATCH 02/12] xfs: zero out di_metatype when removing the metadir file iflag Darrick J. Wong
2026-10-07 13:03 ` Christoph Hellwig
2026-10-05 5:56 ` [PATCH 03/12] xfs: forcibly reset quota timers when upgrading to bigtime during repair Darrick J. Wong
2026-10-07 13:03 ` Christoph Hellwig
2026-10-05 5:56 ` [PATCH 04/12] xfs: don't pass iget failures up when marking ondisk inodes Darrick J. Wong
2026-10-07 13:03 ` Christoph Hellwig [this message]
2026-10-05 5:56 ` [PATCH 05/12] xfs: always reset incore attr fork buffer when resetting fork Darrick J. Wong
2026-10-07 13:04 ` Christoph Hellwig
2026-10-05 5:56 ` [PATCH 06/12] xfs: propagate errors while checking null siblings Darrick J. Wong
2026-10-07 13:04 ` Christoph Hellwig
2026-10-05 5:57 ` [PATCH 07/12] xfs: don't try to scrub self-referential dirent in metapath checker Darrick J. Wong
2026-10-07 13:05 ` Christoph Hellwig
2026-10-05 5:57 ` [PATCH 08/12] xfs: don't allow sm_agno for non-group metadir path checking Darrick J. Wong
2026-10-07 13:05 ` Christoph Hellwig
2026-10-05 5:57 ` [PATCH 09/12] xfs: init inode number for tracepoint Darrick J. Wong
2026-10-07 13:06 ` Christoph Hellwig
2026-10-05 5:57 ` [PATCH 10/12] xfs: release ip after unlinked list store failure Darrick J. Wong
2026-10-07 13:06 ` Christoph Hellwig
2026-10-05 5:58 ` [PATCH 11/12] xfs: always zero the whole shortform header when zeroing attr fork Darrick J. Wong
2026-10-07 13:06 ` Christoph Hellwig
2026-10-05 5:58 ` [PATCH 12/12] xfs: always forget cached ACLs if the attr fork swap succeeds Darrick J. Wong
2026-10-07 13:07 ` Christoph Hellwig
2026-10-08 13:32 ` [PATCHSET] xfs: LLM-inspired bug fixes, part 20 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asZDP2aQ4QUvxWKW@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.