Re: [Buildroot] [PATCH 1/3] package/libtpms: fix typo in HOST_LIBTPMS_CONF_OPTS

[Jarkko Sakkinen via buildroot <buildroot@buildroot.org>]

On Wed, Oct 14, 2026 at 06:46:23PM +0200, Fiona Klute wrote:
> From: "Fiona Klute (othermo GmbH)" <fiona.klute@gmx.de>
> 
> --with-... arguments need two dashes.
> 
> Fixes: b2eec8c6265a38cdba1afadf7f60e0fd00f3b448
> 

By defacto there's no new line here, and it's 12 most significant
bytes of the hash and short summary in parentheses. This is at
least how it has always been in Linux but not 100% sure about
Buildroot. It just looks weird to me.

E.g., I would instead:

Fixes: b2eec8c6265a ("package/libtpms: add host package")

And wold not add the newline. Since this is not kernel, take
with a grain of salt.

> Signed-off-by: Fiona Klute (othermo GmbH) <fiona.klute@gmx.de>
> ---
>  package/libtpms/libtpms.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libtpms/libtpms.mk b/package/libtpms/libtpms.mk
> index 7bc69a50d6..0ece84ae04 100644
> --- a/package/libtpms/libtpms.mk
> +++ b/package/libtpms/libtpms.mk
> @@ -13,6 +13,6 @@ LIBTPMS_INSTALL_STAGING = YES
>  # Required because a plain Git clone is used:
>  HOST_LIBTPMS_AUTORECONF = YES
>  HOST_LIBTPMS_DEPENDENCIES = host-pkgconf host-openssl
> -HOST_LIBTPMS_CONF_OPTS = --with-openssl  -with-tpm2
> +HOST_LIBTPMS_CONF_OPTS = --with-openssl --with-tpm2
>  
>  $(eval $(host-autotools-package))
> -- 
> 2.55.0
> 

I'm not saying this is not right but I'm neither sure whether this
is bug fix or not.

This is a weird because I've used this almost on a daily basis for
Linux kernel QA since I contributed this... Stefan can you help out
resolving the mystery?

Br, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot