Re: [PATCH 1/3] drm/drm_ras: Remove admin-perm flag from list-nodes operation

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Oct 09, 2026 at 10:31:50AM -0700, Zack McKevitt wrote:
> Drivers may want to avoid requiring CAP_NET_ADMIN for subsequent
> drm-ras operations. However, userspace must still be able to access
> the list of RAS nodes to determine the node IDs. So, drop the
> CAP_NET_ADMIN requirement for dumping RAS nodes so that drivers
> with different permission requirements are still able to use the
> interface.
> 
> This prepares the interface to be used for telemetry by the qaic
> driver.
> 
> Signed-off-by: Zack McKevitt <zachary.mckevitt@oss.qualcomm.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  Documentation/netlink/specs/drm_ras.yaml | 1 -
>  drivers/gpu/drm/drm_ras_nl.c             | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/drm_ras.yaml b/Documentation/netlink/specs/drm_ras.yaml
> index 4c2ac9a1ba3f..a88fdab7a1c7 100644
> --- a/Documentation/netlink/specs/drm_ras.yaml
> +++ b/Documentation/netlink/specs/drm_ras.yaml
> @@ -112,7 +112,6 @@ operations:
>             the node IDs. These IDs are required for all subsequent
>             operations on nodes, such as querying error counters.
>        attribute-set: node-attrs
> -      flags: [admin-perm]
>        dump:
>          reply:
>            attributes:
> diff --git a/drivers/gpu/drm/drm_ras_nl.c b/drivers/gpu/drm/drm_ras_nl.c
> index c9f5e0ceb3b5..ff0dc406c27c 100644
> --- a/drivers/gpu/drm/drm_ras_nl.c
> +++ b/drivers/gpu/drm/drm_ras_nl.c
> @@ -46,7 +46,7 @@ static const struct genl_split_ops drm_ras_nl_ops[] = {
>  	{
>  		.cmd	= DRM_RAS_CMD_LIST_NODES,
>  		.dumpit	= drm_ras_nl_list_nodes_dumpit,
> -		.flags	= GENL_ADMIN_PERM | GENL_CMD_CAP_DUMP,
> +		.flags	= GENL_CMD_CAP_DUMP,
>  	},
>  	{
>  		.cmd		= DRM_RAS_CMD_GET_ERROR_COUNTER,
> -- 
> 2.43.0
>