All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	Jean-Philippe Brucker <jpb@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Thierry Reding <thierry.reding@kernel.org>,
	Krishna Reddy <vdumpa@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	<linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH RFC v5 6/6] iommu/arm-smmu-v3: Wire up shared-SID STE ordering and feature gating
Date: Wed, 7 Oct 2026 18:29:49 -0700	[thread overview]
Message-ID: <asbyDdO5dInAkm63@nvidia.com> (raw)
In-Reply-To: <20261006-smmu-shared-sid-v5-6-169a59c671d3@nxp.com>

On Tue, Oct 06, 2026 at 08:19:12PM +0800, Peng Fan (OSS) wrote:
> +static bool arm_smmu_is_shared_sid(struct arm_smmu_master *master)
> +{
> +	return !list_empty(&master->shared_masters_elm);
> +}
> +
> +static bool arm_smmu_skip_shared_ste(struct arm_smmu_device *smmu,
> +				     u32 sid, bool is_abort)
> +{
> +	struct arm_smmu_stream *stream;
> +
> +	lockdep_assert_held(&smmu->streams_mutex);
> +
> +	stream = arm_smmu_find_stream(smmu, sid);
> +	if (!stream || list_empty(&stream->shared_masters))
> +		return false;
> +
> +	if (is_abort)
> +		return true;
> +	if (stream->ste_installed)
> +		return true;
> +	stream->ste_installed = true;
> +	return false;

There is some issue here; check sashiko report:
https://sashiko.dev/#/patchset/20261006-smmu-shared-sid-v5-0-169a59c671d3%40nxp.com

Nicolin

      reply	other threads:[~2026-10-08  1:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 12:19 [PATCH RFC v5 0/6] iommu/arm-smmu-v3: Support shared Stream IDs Peng Fan (OSS)
2026-10-06 12:19 ` [PATCH RFC v5 1/6] iommu/arm-smmu-v3: Don't rb_erase() a never-inserted stream node Peng Fan (OSS)
2026-10-06 12:19 ` [PATCH RFC v5 2/6] iommu/arm-smmu-v3: Allocate streams individually Peng Fan (OSS)
2026-10-07 23:17   ` Nicolin Chen
2026-10-08 13:21     ` Robin Murphy
2026-10-08 17:32       ` Nicolin Chen
2026-10-06 12:19 ` [PATCH RFC v5 3/6] iommu/arm-smmu-v3: Delay stream allocation to inside the mutex Peng Fan (OSS)
2026-10-07 23:55   ` Nicolin Chen
2026-10-08 13:50     ` Peng Fan
2026-10-08 12:55   ` Robin Murphy
2026-10-08 13:49     ` Peng Fan
2026-10-06 12:19 ` [PATCH RFC v5 4/6] iommu/arm-smmu-v3: Support shared SIDs in insert/remove_master Peng Fan (OSS)
2026-10-08  1:02   ` Nicolin Chen
2026-10-08 14:07     ` Peng Fan
2026-10-06 12:19 ` [PATCH RFC v5 5/6] iommu/arm-smmu-v3: Group aliasing devices into the same IOMMU group Peng Fan (OSS)
2026-10-06 12:19 ` [PATCH RFC v5 6/6] iommu/arm-smmu-v3: Wire up shared-SID STE ordering and feature gating Peng Fan (OSS)
2026-10-08  1:29   ` Nicolin Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asbyDdO5dInAkm63@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=jpb@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@kernel.org \
    --cc=vdumpa@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.