Re: [PATCH 3/3] xfs: re-use refcount scrub/repair code for rtrefcount

[Carlos Maiolino <cem@kernel.org>]

On Wed, Oct 07, 2026 at 08:37:57AM -0700, Darrick J. Wong wrote:
> On Wed, Oct 07, 2026 at 10:32:20AM -0500, Eric Sandeen wrote:
> > On 10/7/26 8:51 AM, Christoph Hellwig wrote:
> > > On Fri, Oct 02, 2026 at 04:08:11PM -0500, Eric Sandeen wrote:
> > >> Some code in scrub/rtrefcount.c is copied from scrub/refcount.c; it
> > >> differs only in function & structure names and a couple types and
> > >> macros, which share the same underlying types and values.
> > >>
> > >> Similarly for code in fs/xfs/scrub/[rt]refcount_repair.c
> > >>
> > >> Export the refcount versions, use them for rtrefcount scrubbing,
> > > 
> > > Not really an export fortunately :)
> > 
> > Oh, uh, yeah. I didn't mean like EXPORT_SYMBOL just un-STATIC. :( 
> > 
> > Maybe Carlos fix it to:
> > 
> > Make the refcount versions non-static and use them for rtrefcount scrubbing.

yup, no big deal.

> > 
> > on commit, or I can send another version if needed.
> 
> s/Export/Share/ ?

I went Eric's way, at least looked better for my taste. If you have
any objections, let me know.

> 
> --D
> 
> > > 
> > >> eliminate the copies, and add build-time asserts so that the type/value
> > >> matches mentioned above do not drift.
> > > 
> > >>  5 files changed, 72 insertions(+), 316 deletions(-)
> > > 
> > > Nice code savings!
> > > 
> > > Looks good modulo the commit log nitpick:
> > > 
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > 
> > 
> > Thanks,
> > -Eric
> > 
>