From: Mike Rapoport <rppt@kernel.org>
To: tarunsahu@google.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
dmatlack@google.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, dev.jain@arm.com,
Pratyush Yadav <pratyush@kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v3 2/2] memblock: use binary search to locate candidate regions
Date: Thu, 8 Oct 2026 12:03:38 +0200 [thread overview]
Message-ID: <asdqetdGMXGhtiBh@kernel.org> (raw)
In-Reply-To: <9huzy0c9siyn.fsf@tarunix.c.googlers.com>
On Wed, Oct 07, 2026 at 02:06:56PM +0000, tarunsahu@google.com wrote:
> Mike Rapoport <rppt@kernel.org> writes:
>
> >> +{
> >> + int mid, low = 0;
> >> + int high = type->cnt;
> >> +
> >> + if (type->cnt && base >= type->regions[type->cnt - 1].base +
> >> + type->regions[type->cnt - 1].size)
> >> + return type->cnt;
> >
> > Using local variables would make it more readable IMHO.
>
> removing this as per next comment. Let me know what you think? Should we
> keep this optimization or not.
Yeah, that's fine :)
> ~Tarun
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-10-08 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 9:24 [PATCH v3 1/2] memblock: drop for_each_memblock_type() and open code its users Tarun Sahu
2026-09-26 9:24 ` [PATCH v3 2/2] memblock: use binary search to locate candidate regions Tarun Sahu
2026-09-26 9:31 ` sashiko-bot
2026-09-30 11:33 ` tarunsahu
2026-10-03 7:56 ` Mike Rapoport
2026-10-07 14:06 ` tarunsahu
2026-10-08 10:03 ` Mike Rapoport [this message]
2026-10-04 13:47 ` Pratyush Yadav
2026-10-07 14:05 ` tarunsahu
2026-09-26 9:29 ` [PATCH v3 1/2] memblock: drop for_each_memblock_type() and open code its users sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asdqetdGMXGhtiBh@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=dmatlack@google.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=tarunsahu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.