From: Florian Westphal <fw@strlen.de>
To: Zixuan Chai <petalzu987@gmail.com>
Cc: Ren Wei <weir@nebusec.ai>,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
phil@nwl.cc, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
kaber@trash.net, vega@nebusec.ai
Subject: Re: [PATCH nf 0/1] netfilter: nf_ip6_checksum: validate checksum offset
Date: Thu, 8 Oct 2026 19:24:59 +0200 [thread overview]
Message-ID: <asfR13j04mKUELMQ@strlen.de> (raw)
In-Reply-To: <CADTzadLvrvqbnUipgw4YG+ssa78vm5aUpDSoFZCnwQoOoeMYog@mail.gmail.com>
Zixuan Chai <petalzu987@gmail.com> wrote:
> On Fri, 18 Sept 2026 at 22:15, Florian Westphal <fw@strlen.de> wrote:
> >
> > Florian Westphal <fw@strlen.de> wrote:
> > > > We will provide detailed information about the bug in this email,
> > > > along with a PoC to trigger it.
> > >
> > > patch is fine, but could you make another patch that either fixes
> > > ipv6_find_hdr() or ip6_packet_match() / nft_set_pktinfo_ipv6() as well?
FTR, ipv6_find_hdr() gained this check in
ee319bd3a0e9 ("ipv6: do not let ipv6_find_hdr() return an offset past the packet end")
> > To clarify, I agree with this patch, I don't mean that the other
> > patch should replace this one. I see them as separate issues, so:
>
> When you have a moment, could you please let me know if any further
> changes would be helpful for this patch? I would be happy to send a
> revised version if needed.
netfilter patchwork is clogged up/backlogged, unfortunately.
> > ipv6_skip_exthdr() may have the same issue.
>
> I have also been looking into the ipv6_skip_exthdr() issue you
> mentioned. I think it needs further evaluation, but so far I have
> not been able to construct a PoC similar to the one for the
> checksum issue.
> One attempt is this series:
> https://lore.kernel.org/all/cover.1790082243.git.petalzu987@gmail.com/
>
> I am not sure whether this issue warrants a fix, so I would
> appreciate your thoughts on whether it is worth pursuing.
Wrt 2/2 Eric is right, I never reported an issue with i40e.
The ipv6_skip_exthdr() change in patch 1/2 looks good to me.
The other changes in 1/2 should probably be in a different patch;
I feel its doing too many different things at the same time.
next prev parent reply other threads:[~2026-10-08 17:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 9:26 [PATCH nf 0/1] netfilter: nf_ip6_checksum: validate checksum offset Ren Wei
2026-09-18 9:26 ` [PATCH nf 1/1] " Ren Wei
2026-09-18 10:38 ` [PATCH nf 0/1] " Florian Westphal
2026-09-18 11:33 ` Pablo Neira Ayuso
2026-09-18 14:15 ` Florian Westphal
2026-09-19 14:35 ` Zixuan Chai
2026-10-08 16:01 ` Zixuan Chai
2026-10-08 17:24 ` Florian Westphal [this message]
2026-10-08 23:29 ` Pablo Neira Ayuso
2026-10-09 0:05 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asfR13j04mKUELMQ@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaber@trash.net \
--cc=kuba@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=petalzu987@gmail.com \
--cc=phil@nwl.cc \
--cc=vega@nebusec.ai \
--cc=weir@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.