From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: amitsd@google.com
Cc: "Badhri Jagan Sridharan" <badhri@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>,
"RD Babiera" <rdbabiera@google.com>,
"Kyle Tso" <kyletso@google.com>
Subject: Re: [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources
Date: Fri, 9 Oct 2026 13:19:44 +0200 [thread overview]
Message-ID: <asjN0HNpriZtFnrf@black.igk.intel.com> (raw)
In-Reply-To: <20261001-max77759-icl-typec-v1-0-99ada1f65ced@google.com>
On Thu, Oct 01, 2026 at 10:51:12PM +0000, Amit Sunil Dhamne via B4 Relay wrote:
> As per Sec. 4.6.2.1 of the Type-C cable & connector spec when the
> source advertises Rp-default, the current limit is set as per the
> USB 2.0/USB 3.2 specification, BC1.2 specification as applicable or the
> PD negotiation.
>
> Reset value for the Input Current Limit register for the MAX77759
> charger is 500 mA. Prior to the max77759_charger driver, the battery
> would always charge at that limit since it wasn't re-programmed. Since
> the driver was introduced, for any non-PD source advertising Rp-default,
> the charger turns off as tcpm reports the current limit to be 0. The
> max77759_charger driver reads POWER_SUPPLY_PROP_CURRENT_MAX from the
> "tcpm-source" power supply that tcpm_set_current_limit() updates, and
> programs its input current limit from it. The limit is 0 because the
> tcpm doesn't have visibility on the USB data speed or BC1.2 detection.
> As a workaround for the Rp-default case, let the Type-C stack report a
> USB 2.0 current limit of 500 mA so that the behavior is at parity with
> what was before. This is until we implement a conduit for USB core to
> communicate with the Type-C stack.
>
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> Amit Sunil Dhamne (3):
> usb: typec: tcpm: only call get_current_limit() for cc=Rp-def
> usb: typec: tcpci: implement get_current_limit
> usb: typec: tcpci_maxim: implement get_current_limit
>
> drivers/usb/typec/tcpm/tcpci.c | 14 ++++++++++++++
> drivers/usb/typec/tcpm/tcpci_maxim_core.c | 15 +++++++++++++++
> drivers/usb/typec/tcpm/tcpm.c | 7 +++----
> include/linux/usb/tcpci.h | 6 ++++++
> 4 files changed, 38 insertions(+), 4 deletions(-)
> ---
> base-commit: 551c722f40809618230001baccf219193e22fc5a
> change-id: 20260918-max77759-icl-typec-8dfb9f83d712
>
> Best regards,
> --
> Amit Sunil Dhamne <amitsd@google.com>
For the series:
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
--
heikki
next prev parent reply other threads:[~2026-10-09 11:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 22:51 [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources Amit Sunil Dhamne via B4 Relay
2026-10-01 22:51 ` Amit Sunil Dhamne
2026-10-01 22:51 ` [PATCH 1/3] usb: typec: tcpm: only call get_current_limit() for cc=Rp-def Amit Sunil Dhamne via B4 Relay
2026-10-01 22:51 ` Amit Sunil Dhamne
2026-10-02 9:48 ` André Draszik
2026-10-01 22:51 ` [PATCH 2/3] usb: typec: tcpci: implement get_current_limit Amit Sunil Dhamne via B4 Relay
2026-10-01 22:51 ` Amit Sunil Dhamne
2026-10-01 22:51 ` [PATCH 3/3] usb: typec: tcpci_maxim: " Amit Sunil Dhamne via B4 Relay
2026-10-01 22:51 ` Amit Sunil Dhamne
2026-10-09 11:19 ` Heikki Krogerus [this message]
2026-10-09 11:32 ` [PATCH 0/3] usb: typec: report a current limit for non-PD Rp-def sources Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asjN0HNpriZtFnrf@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=amitsd@google.com \
--cc=andre.draszik@linaro.org \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.