From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 11/15] ujson: reader: Support files with zero lseek size
Date: Fri, 9 Oct 2026 17:21:53 +0200 [thread overview]
Message-ID: <askGkW1V_iHKXMJM@yuki.lan> (raw)
In-Reply-To: <20261005-fix_core_lib_deepseek-v1-11-fec334ce8e80@suse.com>
Hi!
> Files in pseudo-filesystems like /proc/sys report a size of 0 with
> lseek(), causing ujson_reader_load() to allocate a 1-byte buffer and
> skip the read loop entirely. seq_file based files such as
> /proc/self/status do not support SEEK_END at all, making the load fail.
> Allocate an initial capacity when the size is unknown and grow the
> buffer with realloc() dynamically until EOF.
I would say that the proper fix here is to err out on lseek() returning
zero. I do not think that it make sense to support loading JSON from a
sysfs until we really need that.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-10-09 15:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 13:25 [LTP] [PATCH 00/15] Fix ujson bugs Andrea Cervesato
2026-10-05 13:25 ` [LTP] [PATCH 01/15] ujson: Fix 4-byte UTF-8 sequence decoding Andrea Cervesato
2026-10-05 14:57 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 02/15] ujson: writer: Fix OOB read on invalid UTF-8 Andrea Cervesato
2026-10-05 15:04 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 03/15] ujson: reader: Prevent infinite loop on EOF Andrea Cervesato
2026-10-05 15:12 ` Cyril Hrubis
2026-10-05 18:06 ` [LTP] ujson: Fix 4-byte UTF-8 sequence decoding linuxtestproject.agent
2026-10-05 13:25 ` [LTP] [PATCH 04/15] ujson: writer: Fix open() return value check Andrea Cervesato
2026-10-05 15:15 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 05/15] ujson: reader: Combine UTF-16 surrogate pairs Andrea Cervesato
2026-10-05 15:36 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 06/15] ujson: reader: Check for signed integer overflow Andrea Cervesato
2026-10-09 11:59 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 07/15] ujson: writer: Return error when newline() fails Andrea Cervesato
2026-10-09 13:44 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 08/15] ujson: writer: Check return value in ESC_FLUSH Andrea Cervesato
2026-10-09 14:01 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 09/15] ujson: reader: Do not increment depth on overflow Andrea Cervesato
2026-10-09 14:15 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 10/15] ujson: reader: Parse escape sequences in object IDs Andrea Cervesato
2026-10-05 13:25 ` [LTP] [PATCH 11/15] ujson: reader: Support files with zero lseek size Andrea Cervesato
2026-10-09 15:21 ` Cyril Hrubis [this message]
2026-10-05 13:25 ` [LTP] [PATCH 12/15] ujson: reader: Reject \u0000 escape in strings Andrea Cervesato
2026-10-09 15:24 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 13/15] ujson: writer: Set errno when a flush fails Andrea Cervesato
2026-10-09 15:46 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 14/15] ujson: writer: Advance buffer on short write Andrea Cervesato
2026-10-09 15:52 ` Cyril Hrubis
2026-10-05 13:25 ` [LTP] [PATCH 15/15] ujson: writer: Flush buffer before direct writes Andrea Cervesato
2026-10-09 16:05 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=askGkW1V_iHKXMJM@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.