From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,
"open list:RISC-V TCG target" <qemu-riscv@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] tcg/riscv64: Fix vector constant matching for logical ops
Date: Fri, 9 Oct 2026 20:02:15 +0200 [thread overview]
Message-ID: <asksJ0sjVi9BZ5m0@aurel32.net> (raw)
In-Reply-To: <118805f8-bc4c-4600-b156-5b494a840ef5@linaro.org>
Hi,
On 2026-10-09 07:05, Richard Henderson wrote:
> On 10/8/26 20:16, Aurelien Jarno wrote:
> > + if ((vece != MO_8) || (val == (uint8_t)val * 0x0101010101010101ull)) {
>
> Do you really want
>
> val = dup_const(vece, val)
>
> ?
No, I do not want that, as vece is not defined (in practice is 0 aka
MO_8) for logical ops.
What I want is really extracting the element only if:
- vece != MO_8
=> This means VECE is defined (not 0), so it is possible to blindly
extract a single element.
OR
- val == dup_const(vece, val)
=> When VECE is possibly undefined, this checks that the constant can be
properly represented as an element replicated using VECE.
Or maybe you just mean to replace the check by
+ if ((vece != MO_8) || (val == dup_const(vece, val))) {
?
Regards
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
next prev parent reply other threads:[~2026-10-09 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 18:16 [PATCH] tcg/riscv64: Fix vector constant matching for logical ops Aurelien Jarno
2026-10-09 5:05 ` Richard Henderson
2026-10-09 18:02 ` Aurelien Jarno [this message]
2026-10-09 21:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asksJ0sjVi9BZ5m0@aurel32.net \
--to=aurelien@aurel32.net \
--cc=Alistair.Francis@wdc.com \
--cc=daniel.barboza@oss.qualcomm.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.