From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Luna Hart <lhart.opensource@witekio.com>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Flaviu Nistor <flaviu.nistor@gmail.com>
Subject: Re: [PATCH 2/2] hwmon: (tps38900x) Add driver for TI TPS389004/TPS389006/TPS389008
Date: Mon, 12 Oct 2026 12:57:34 +0200 [thread overview]
Message-ID: <asy8rKc0bLUo2xCK@monoceros> (raw)
In-Reply-To: <20260929-lhart-dev-tps38900x-v1-2-7045c5894152@witekio.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hello,
On Tue, Sep 29, 2026 at 04:04:05PM -0700, Luna Hart wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
You can rely on <linux/i2c.h> to provide of_device_id and i2c_device_id
and drop <linux/mod_devicetable.h>.
The mod_devicetable.h header pulls in many unneeded dependencies and is
bad for this reason.
> [...]
> +static const struct i2c_device_id tps38900x_id[] = {
> + { .name = "tps389004", .driver_data = 4 },
> + { .name = "tps389006", .driver_data = 6 },
> + { .name = "tps389008", .driver_data = 8 },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, tps38900x_id);
> +
> +static const struct of_device_id tps38900x_of_match[] = {
> + { .compatible = "ti,tps389004", .data = (void *)4 },
> + { .compatible = "ti,tps389006", .data = (void *)6 },
> + { .compatible = "ti,tps389008", .data = (void *)8 },
> + {}
Please use { } with a space in the list terminator.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-10-12 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 23:04 [PATCH 0/2] hwmon: Add support for TI TPS389004/TPS389006/TPS389008 Luna Hart
2026-09-29 23:04 ` Luna Hart via B4 Relay
2026-09-29 23:04 ` [PATCH 1/2] dt-bindings: hwmon: Add " Luna Hart
2026-09-29 23:04 ` Luna Hart via B4 Relay
2026-09-29 23:17 ` sashiko-bot
2026-09-30 23:28 ` Luna HART
2026-10-01 8:17 ` Krzysztof Kozlowski
2026-10-01 8:17 ` Krzysztof Kozlowski
2026-10-02 23:57 ` Luna Hart
2026-09-29 23:04 ` [PATCH 2/2] hwmon: (tps38900x) Add driver for " Luna Hart
2026-09-29 23:04 ` Luna Hart via B4 Relay
2026-09-29 23:14 ` sashiko-bot
2026-10-01 8:19 ` Krzysztof Kozlowski
2026-10-03 0:13 ` Luna Hart
2026-10-12 10:57 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asy8rKc0bLUo2xCK@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lhart.opensource@witekio.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.