From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7DDDCA9EC5 for ; Mon, 12 Oct 2026 08:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TAu45KbNnbEGXqfcTXap91i5M76XosIqq54PsGr+p2g=; b=SgNX5MavJgnvPv 5UffVNknssBSqm+AQcekgHDjhbvfx61Pxk3p0MGBRte/nmYfwIuhsW/gHuflhp6QIJpzGx/+ql1Mp m1ZZhkZqbNNQyuhfx6rBjHFq6LJx3ojCsINL8LBwzYjGY4+8pQchxFAuCIi6lr8DAnmu/yDgUDGpU adwnDfhPbovaBvSKQh8kQ0llxfFVAkEpmNdUdvdYz9sTGEF1JvLuypFLo16VydHx8s2yoT3BSuw6E LVg+puoV47zclXGpw83Fn6TcdKpm5OgFo3QS7JQJAX10WejA85jPx+Ta3C9eSNhHQfCknMZovQsGB A/i03M/S36JMT/llLLvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGB73-00000009uBd-21m7; Mon, 12 Oct 2026 08:10:25 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGB72-00000009uBQ-3HEr for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 08:10:24 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 323F9404C4; Mon, 12 Oct 2026 08:10:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16ADF1F0089B; Mon, 12 Oct 2026 08:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791792624; bh=QevQ6Tupp6Y5Q71lWFERf3zC8gS1eFojsFS0KOuxiFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dh36JnY3MrEljugYPHQ4jd4BIPja9n9k7ZVGK3AWn07KWrVB8fQM8wuvZWx32u3wE +8goqAUnr/WuEsLk03lJ/U+/ip7dx2lKlGAMGapQ6c6wvIFu8/Kgg9dBqE3Q1JWujE ZhSRokkDQ88G2LYd9tynhE8kPeexazdpEdpaxq+6Kci36AIOHLhwlDLLBz3qONQg7s Gtyzct177n25BDDyCKYWsRR1hfW8bfZHTMHQ/vjFFr7c/u0UeiFCTVIx0bYMDrjhAZ YjYKiaNqECpTwJR8Pgy3X/J5Xh5JvNqYyZX/+56C6Qmj1erbDlZuQQ9UPacl//Bnfr Yfnyq0TB+Tzyw== Date: Mon, 12 Oct 2026 13:40:13 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Neil Armstrong , Christian Marangi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 05/10] phy: qcom-ipq806x-usb: fix the SS PHY TEST_POWERDOWN bit Message-ID: References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMTAsIDIwMjYgYXQgMDI6NDI6MzVQTSArMDMwMCwgRG1pdHJ5IEJhcnlzaGtv diB3cm90ZToKPiBUaGUgU1MgUEhZIGV4aXQgc2VxdWVuY2UgdHJpZXMgdG8gcHV0IHRoZSBQSFkg aW50byByZXRlbnRpb24gdmlhIHRoZQo+IFRFU1RfUE9XRVJET1dOIGJpdCBvZiBTU19QSFlfQ1RS TCwgYnV0IGRlZmluZXMgdGhhdCBiaXQgYXMgQklUKDI3KS4gSW4KPiB0aGUgRFdDMyBRU0NSQVRD SCBTU19QSFlfQ1RSTCByZWdpc3RlciBURVNUX1BPV0VSRE9XTiBpcyBiaXQgMjYgKHNlZQo+IHRo ZSBkb3duc3RyZWFtIHBoeS1tc20tc3N1c2IgZHJpdmVyIGZvciB0aGUgc2FtZSBJUCBnZW5lcmF0 aW9uKSwgc28gdGhlCj4gc2VxdWVuY2UgcG9rZXMgYW4gdW5yZWxhdGVkIGJpdCBhbmQgdGhlIFBI WSBpcyBuZXZlciBwb3dlcmVkIGRvd24uCj4gCj4gRml4ZXM6IGVmMTliMTE3YjgzNCAoInBoeTog cXVhbGNvbW06IGFkZCBxY29tIGlwcTgwNnggZHdjIHVzYiBwaHkgZHJpdmVyIikKPiBBc3Npc3Rl ZC1ieTogQ2xhdWRlOmNsYXVkZS1mYWJsZS01Cj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IEJhcnlz aGtvdiA8ZG1pdHJ5LmJhcnlzaGtvdkBvc3MucXVhbGNvbW0uY29tPgoKUmV2aWV3ZWQtYnk6IE1h bml2YW5uYW4gU2FkaGFzaXZhbSA8bWFuaXZhbm5hbi5zYWRoYXNpdmFtQG9zcy5xdWFsY29tbS5j b20+CgotIE1hbmkKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a 4K6/4K614K6u4K+NCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AC6D431A56; Mon, 12 Oct 2026 08:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791792625; cv=none; b=eW+4ngdsKqvkTcYp3Ur9adJg7oLq/XasquH+o5zjQjD5eueEB/Yey/uHGME3JyJ/qAB150JF3tnM/RB94xvJjo3Jdd7wdMm7J2u7D7bJg6Mtx15DtGKXMu8gsowtl2WMzdvBjD5t0I8CYzkMiy1h1+laQbuxvsH26AEGBsFA27A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791792625; c=relaxed/simple; bh=+VVo/JGBJ90aJN5ZdrAr9+J3UW3a8r4MnFeZa9+hYts=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJzUltFAUCfuaJTLsvcDys9tZwke/qdRnNWIExLWt5IpdIkBatcJbmGmwv53xBUyJgvDjUsn3vxRm+pEYdzb4OdJjXhVNBc+C0P2KEAzNTU6KOPgUIFVuOWWbAb5rfu6unRqXxncgce36j7cRxE7VjtCMfsbAP/AYUts3/gRIRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dh36JnY3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dh36JnY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16ADF1F0089B; Mon, 12 Oct 2026 08:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791792624; bh=QevQ6Tupp6Y5Q71lWFERf3zC8gS1eFojsFS0KOuxiFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dh36JnY3MrEljugYPHQ4jd4BIPja9n9k7ZVGK3AWn07KWrVB8fQM8wuvZWx32u3wE +8goqAUnr/WuEsLk03lJ/U+/ip7dx2lKlGAMGapQ6c6wvIFu8/Kgg9dBqE3Q1JWujE ZhSRokkDQ88G2LYd9tynhE8kPeexazdpEdpaxq+6Kci36AIOHLhwlDLLBz3qONQg7s Gtyzct177n25BDDyCKYWsRR1hfW8bfZHTMHQ/vjFFr7c/u0UeiFCTVIx0bYMDrjhAZ YjYKiaNqECpTwJR8Pgy3X/J5Xh5JvNqYyZX/+56C6Qmj1erbDlZuQQ9UPacl//Bnfr Yfnyq0TB+Tzyw== Date: Mon, 12 Oct 2026 13:40:13 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Neil Armstrong , Christian Marangi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 05/10] phy: qcom-ipq806x-usb: fix the SS PHY TEST_POWERDOWN bit Message-ID: References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260810-msm8974-usb3-v1-5-1a47e1185524@oss.qualcomm.com> On Mon, Aug 10, 2026 at 02:42:35PM +0300, Dmitry Baryshkov wrote: > The SS PHY exit sequence tries to put the PHY into retention via the > TEST_POWERDOWN bit of SS_PHY_CTRL, but defines that bit as BIT(27). In > the DWC3 QSCRATCH SS_PHY_CTRL register TEST_POWERDOWN is bit 26 (see > the downstream phy-msm-ssusb driver for the same IP generation), so the > sequence pokes an unrelated bit and the PHY is never powered down. > > Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov Reviewed-by: Manivannan Sadhasivam - Mani -- மணிவண்ணன் சதாசிவம்