From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1C8142589C; Mon, 12 Oct 2026 08:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791793192; cv=none; b=tLDorjhurvCN8gp8e/k8Zipu4HmQOTW+2XPqaS6QSe2xhOaWNtFYX3ghMX6FZgugsDT76TJF1fPSzBQLFzGOg+6wTmC60sTDI/2gTfnfYv29QnSoV7hp4MJ4k8kAm4kx0huvqjfL+CZxtBYb6zDNWJ7H7jxwvEZVaykgc6bVkqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791793192; c=relaxed/simple; bh=gmzjOOSF7twJel4VeHM/+0xsEa2hrSgbS2bdTCWg1Sc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PryTCsA5gCmgFRLARvhT0MseUppuwPuelEkYfAKGBIjLz9xqKumtKYnhqTaKNUSk8OBDqi4oLt1qmX9fNdsuzPqa5oxPRc1nYIbgZM7djuZ936T4WgsBZhF257SYW1+4hl346UXihlh1sN2nDndPKbv4Tjq4LsukfaTUqLYargU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IovvEw23; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IovvEw23" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 785E41F0089B; Mon, 12 Oct 2026 08:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791793191; bh=Pt8dgJWek7/0/LhAmTZzYWHs1dc5eBB3jyEzUfzCwPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IovvEw23o4JOxMRvlwPv5HJ/Hb2AlhEMasVk4bqSR24fsLDUuhRyAPI0AgbmBJMPc +qAz7NmiPAtyG0ZsfnDymrKSQh4ehZhJabtS3NNn3aACrcYSFQBo4ZvKb0yxsQjHxF LOLbsY+g2AVfDu2ZklCRbNp8KzHtSNehYfV+DkAda1sjGWqvkHAM4TMLF71ekvTvRR qIuYNlm9CfvFJJndbVYYaA57HqvVdCSlbiKb/OeUD3nTgzkh305qZ8cqtBTKvLtW5K dq2H5dgG/nogXHksvD+yNTlejovr9RGqWVfMYiZg6F1qEyzU1qMfQSPh/pFp5KH5zG CfEgrdE714Ehw== Date: Mon, 12 Oct 2026 13:49:41 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Neil Armstrong , Christian Marangi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 06/10] phy: qcom-ipq806x-usb: fix the PHY_PARAM_CTRL1 field masks Message-ID: References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-6-1a47e1185524@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260810-msm8974-usb3-v1-6-1a47e1185524@oss.qualcomm.com> On Mon, Aug 10, 2026 at 02:42:36PM +0300, Dmitry Baryshkov wrote: > Each of the PHY_PARAM_CTRL1 field masks extends one bit below its > documented field: TX_FULL_SWING [26:20] is coded as GENMASK(26, 19), > TX_DEEMPH_6DB [19:14] as GENMASK(19, 13), TX_DEEMPH_3_5DB [13:8] as > GENMASK(13, 7) and LOS_BIAS [7:3] as GENMASK(7, 2). Also, the field > described as LOS_BIAS in reality is called LOS_LEVEL. FIELD_PREP against > these masks places every value one bit short of its field, so the > programmed swing/de-emphasis/LOS parameters land shifted and the > neighbouring fields are corrupted; the masked write-readback in the SS > PHY init reports 'write: ... to QSCRATCH: 4 FAILED'. > > Align the masks with the documented field positions. > > Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov Reviewed-by: Manivannan Sadhasivam - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BD14CA9EDD for ; Mon, 12 Oct 2026 08:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uOQNze7CTRZixHfXP2O8J2tOSYlcSEAQCHxHGl9oA80=; b=24DnW2hna9WZQB RalrybiDWqLe25bU5tfg9rM7sxkjilsS9JfPOOhYIK5RkDfsej/KNX80nkUTUmVCJCNDxYYUuHILZ AjUG6bcoErT32FQsrdBo1PlMxkp0NKL30ZlFhv0lI1ZMRZ/tICBjV5QRthUPbzkaO4KqQlvLEyfVB njv3f9Lo67O+ATrE/a1n6Sr3houiujZhCxRv7QpzIeEgEDpDOSaiMxMBRDp7KSA+uUpNEkr1s7Blt /D059hXkChrwwjZolUNifEkAb5L0ZXxorfu7OqITffizxkEd8fF0cTLj0kJ+ZrvYTLJZT/6IzkY9z dOXwaYIW7F7JQoTLyAdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBGC-00000009vBH-3ZaH; Mon, 12 Oct 2026 08:19:52 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBGB-00000009vB7-2aVa for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 08:19:51 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 60B0D41A84; Mon, 12 Oct 2026 08:19:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 785E41F0089B; Mon, 12 Oct 2026 08:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791793191; bh=Pt8dgJWek7/0/LhAmTZzYWHs1dc5eBB3jyEzUfzCwPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IovvEw23o4JOxMRvlwPv5HJ/Hb2AlhEMasVk4bqSR24fsLDUuhRyAPI0AgbmBJMPc +qAz7NmiPAtyG0ZsfnDymrKSQh4ehZhJabtS3NNn3aACrcYSFQBo4ZvKb0yxsQjHxF LOLbsY+g2AVfDu2ZklCRbNp8KzHtSNehYfV+DkAda1sjGWqvkHAM4TMLF71ekvTvRR qIuYNlm9CfvFJJndbVYYaA57HqvVdCSlbiKb/OeUD3nTgzkh305qZ8cqtBTKvLtW5K dq2H5dgG/nogXHksvD+yNTlejovr9RGqWVfMYiZg6F1qEyzU1qMfQSPh/pFp5KH5zG CfEgrdE714Ehw== Date: Mon, 12 Oct 2026 13:49:41 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Neil Armstrong , Christian Marangi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 06/10] phy: qcom-ipq806x-usb: fix the PHY_PARAM_CTRL1 field masks Message-ID: References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-6-1a47e1185524@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810-msm8974-usb3-v1-6-1a47e1185524@oss.qualcomm.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMTAsIDIwMjYgYXQgMDI6NDI6MzZQTSArMDMwMCwgRG1pdHJ5IEJhcnlzaGtv diB3cm90ZToKPiBFYWNoIG9mIHRoZSBQSFlfUEFSQU1fQ1RSTDEgZmllbGQgbWFza3MgZXh0ZW5k cyBvbmUgYml0IGJlbG93IGl0cwo+IGRvY3VtZW50ZWQgZmllbGQ6IFRYX0ZVTExfU1dJTkcgWzI2 OjIwXSBpcyBjb2RlZCBhcyBHRU5NQVNLKDI2LCAxOSksCj4gVFhfREVFTVBIXzZEQiBbMTk6MTRd IGFzIEdFTk1BU0soMTksIDEzKSwgVFhfREVFTVBIXzNfNURCIFsxMzo4XSBhcwo+IEdFTk1BU0so MTMsIDcpIGFuZCBMT1NfQklBUyBbNzozXSBhcyBHRU5NQVNLKDcsIDIpLiBBbHNvLCB0aGUgZmll bGQKPiBkZXNjcmliZWQgYXMgTE9TX0JJQVMgaW4gcmVhbGl0eSBpcyBjYWxsZWQgTE9TX0xFVkVM LiBGSUVMRF9QUkVQIGFnYWluc3QKPiB0aGVzZSBtYXNrcyBwbGFjZXMgZXZlcnkgdmFsdWUgb25l IGJpdCBzaG9ydCBvZiBpdHMgZmllbGQsIHNvIHRoZQo+IHByb2dyYW1tZWQgc3dpbmcvZGUtZW1w aGFzaXMvTE9TIHBhcmFtZXRlcnMgbGFuZCBzaGlmdGVkIGFuZCB0aGUKPiBuZWlnaGJvdXJpbmcg ZmllbGRzIGFyZSBjb3JydXB0ZWQ7IHRoZSBtYXNrZWQgd3JpdGUtcmVhZGJhY2sgaW4gdGhlIFNT Cj4gUEhZIGluaXQgcmVwb3J0cyAnd3JpdGU6IC4uLiB0byBRU0NSQVRDSDogNCBGQUlMRUQnLgo+ IAo+IEFsaWduIHRoZSBtYXNrcyB3aXRoIHRoZSBkb2N1bWVudGVkIGZpZWxkIHBvc2l0aW9ucy4K PiAKPiBGaXhlczogZWYxOWIxMTdiODM0ICgicGh5OiBxdWFsY29tbTogYWRkIHFjb20gaXBxODA2 eCBkd2MgdXNiIHBoeSBkcml2ZXIiKQo+IEFzc2lzdGVkLWJ5OiBDbGF1ZGU6Y2xhdWRlLWZhYmxl LTUKPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgQmFyeXNoa292IDxkbWl0cnkuYmFyeXNoa292QG9z cy5xdWFsY29tbS5jb20+CgpSZXZpZXdlZC1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5p dmFubmFuLnNhZGhhc2l2YW1Ab3NzLnF1YWxjb21tLmNvbT4KCi0gTWFuaQoKLS0gCuCuruCuo+Cu v+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCi0tIApsaW51eC1w aHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=