From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B54C44AB88; Mon, 12 Oct 2026 08:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791794128; cv=none; b=qXPNCHtRq+kFp8Y+9BIQsrjlk00K58hua7DzHSxyclgOxycwEDm5WCjrjrS/7FtJTGm/9Fq6MDR8mucI1vdqbvXgdI//7Mq51C0QoboxQ8Ho9utZtvQc1MKBIvCNJYP2brGWW8H+mpIFeTTvGAqwkXxEKpcHi+sqSLn6cCojfjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791794128; c=relaxed/simple; bh=ZY973Ic+lb7IfmmYgmhImfgw151pGl2uTh05CSs+GmM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YaEMym5rJ+IMJu9Dk4ga9hb1FLLdIitnnSzVGd+va1+gcDqM3XekDThtjZpglLrM38C64d6JqV+7PGvHHLtEtUyuxG2Cnf9lXTL8vHKXiES4dDJgIzgoyodaHqJjNWhh2caaNYWfPpejNRA2bwsnIyKqbK63Jhfg8eTNyyc7VhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AEXN6J0r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AEXN6J0r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED8721F0089B; Mon, 12 Oct 2026 08:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791794127; bh=DaE/ux2Y0gwxFVPnyRYtU9HcRApd/zjO6wXFG/Z4XA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AEXN6J0rMO+atMJUjcW+1/xyq8sQAeMCPdWE2TD+x6X9azVZp60nWbQMDxPT4S4pY tsPjP3s5ICPS+9xtTEpYQF2ArnIflnIgX3PBjJXyIU9xD7+9CJOGzZUIkUr28tRllU OpgWdmFr4XHryBP5ceuO7AbclnGr+nzoYeXex5FL+trwrEEVMLUo6aZpHPsyyYkHvD Knjx6J2aPnt/cy1uDb8Rd8k+B8vDydIW9WeG+ub4hctoxkX9iP/piD32pi7NFejRRh yBPfuJNjSFy8SbQn2eo1BTl5+mvUyS/lK7jzIpncgKIBZyu9lIcMHwJNHaESqLJjSd jv93D1uMjA85Q== Date: Mon, 12 Oct 2026 14:05:14 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen Subject: Re: [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Message-ID: References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-3-e5f93ea76ffa@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260810-msm8974-usb-hsic-v1-3-e5f93ea76ffa@oss.qualcomm.com> On Mon, Aug 10, 2026 at 06:42:07PM +0300, Dmitry Baryshkov wrote: > With the cal_sleep (32 kHz IO calibration sleep) clock running, the > HSIC PHY engages its sleep calibration: the strobe/data pad > calibration converges to different values than with the active > calibration alone, HSIC_CFG reports the sleep calibration state, and > the port no longer detects a device connect - an onboard HSIC hub > signalling its attach after reset is never seen (observed on the > APQ8074 Dragonboard against its USB4604 hub, by comparing the ULPI > register state against the vendor kernel, which never enables this > clock: with cal_sleep enabled ULPI HSIC_CFG reads 0xab and the pad > registers 0x0f/0x0d, without it 0xa9 and 0x10/0x10, matching the > working vendor configuration). > > Stop requesting and enabling the cal_sleep clock. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Dmitry Baryshkov Reviewed-by: Manivannan Sadhasivam - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7184ACA9ED0 for ; Mon, 12 Oct 2026 08:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vvr0/vsjeBl52kNr5Fpn0cGod0+ROOv5Rojj0SQ+iII=; b=MXyK/AA5vcLxDM FQVQuPBqHd6kUZ4N2jmgPKC5dX6hHKIRToWw9/xORFufEw0jcuzCbUaEba1uidX6EfnRdbmyGuQqV HbXmc2eRO9KtbU70STXrfFu+ikXVmfxGbH6Y3AFPIbiyuIKGrTfjjJDMr5XWTk+mcqQapV+sBpwJ1 5BR4VAVhTkROBN8koL7jkMEejTyN60ftzwwm55BYldLEHSSLEonD/xrUGcH+9P5NJQpyHU1QnFeLV YBa51B/IsFCznb7p1tNCY7KtCcdXb0/S91CnOAYhuXKJo+DtX4vgpc/dLYv7wrRFXyGDNVCfBW70N qQYGb8IEQeJvUpT9qvJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBVI-00000009x13-3yxT; Mon, 12 Oct 2026 08:35:28 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBVI-00000009x0p-1xnO for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 08:35:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 89CE460DAC; Mon, 12 Oct 2026 08:35:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED8721F0089B; Mon, 12 Oct 2026 08:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791794127; bh=DaE/ux2Y0gwxFVPnyRYtU9HcRApd/zjO6wXFG/Z4XA8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AEXN6J0rMO+atMJUjcW+1/xyq8sQAeMCPdWE2TD+x6X9azVZp60nWbQMDxPT4S4pY tsPjP3s5ICPS+9xtTEpYQF2ArnIflnIgX3PBjJXyIU9xD7+9CJOGzZUIkUr28tRllU OpgWdmFr4XHryBP5ceuO7AbclnGr+nzoYeXex5FL+trwrEEVMLUo6aZpHPsyyYkHvD Knjx6J2aPnt/cy1uDb8Rd8k+B8vDydIW9WeG+ub4hctoxkX9iP/piD32pi7NFejRRh yBPfuJNjSFy8SbQn2eo1BTl5+mvUyS/lK7jzIpncgKIBZyu9lIcMHwJNHaESqLJjSd jv93D1uMjA85Q== Date: Mon, 12 Oct 2026 14:05:14 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen Subject: Re: [PATCH 03/10] phy: qcom-usb-hsic: do not run the sleep calibration clock Message-ID: References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-3-e5f93ea76ffa@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810-msm8974-usb-hsic-v1-3-e5f93ea76ffa@oss.qualcomm.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMTAsIDIwMjYgYXQgMDY6NDI6MDdQTSArMDMwMCwgRG1pdHJ5IEJhcnlzaGtv diB3cm90ZToKPiBXaXRoIHRoZSBjYWxfc2xlZXAgKDMyIGtIeiBJTyBjYWxpYnJhdGlvbiBzbGVl cCkgY2xvY2sgcnVubmluZywgdGhlCj4gSFNJQyBQSFkgZW5nYWdlcyBpdHMgc2xlZXAgY2FsaWJy YXRpb246IHRoZSBzdHJvYmUvZGF0YSBwYWQKPiBjYWxpYnJhdGlvbiBjb252ZXJnZXMgdG8gZGlm ZmVyZW50IHZhbHVlcyB0aGFuIHdpdGggdGhlIGFjdGl2ZQo+IGNhbGlicmF0aW9uIGFsb25lLCBI U0lDX0NGRyByZXBvcnRzIHRoZSBzbGVlcCBjYWxpYnJhdGlvbiBzdGF0ZSwgYW5kCj4gdGhlIHBv cnQgbm8gbG9uZ2VyIGRldGVjdHMgYSBkZXZpY2UgY29ubmVjdCAtIGFuIG9uYm9hcmQgSFNJQyBo dWIKPiBzaWduYWxsaW5nIGl0cyBhdHRhY2ggYWZ0ZXIgcmVzZXQgaXMgbmV2ZXIgc2VlbiAob2Jz ZXJ2ZWQgb24gdGhlCj4gQVBRODA3NCBEcmFnb25ib2FyZCBhZ2FpbnN0IGl0cyBVU0I0NjA0IGh1 YiwgYnkgY29tcGFyaW5nIHRoZSBVTFBJCj4gcmVnaXN0ZXIgc3RhdGUgYWdhaW5zdCB0aGUgdmVu ZG9yIGtlcm5lbCwgd2hpY2ggbmV2ZXIgZW5hYmxlcyB0aGlzCj4gY2xvY2s6IHdpdGggY2FsX3Ns ZWVwIGVuYWJsZWQgVUxQSSBIU0lDX0NGRyByZWFkcyAweGFiIGFuZCB0aGUgcGFkCj4gcmVnaXN0 ZXJzIDB4MGYvMHgwZCwgd2l0aG91dCBpdCAweGE5IGFuZCAweDEwLzB4MTAsIG1hdGNoaW5nIHRo ZQo+IHdvcmtpbmcgdmVuZG9yIGNvbmZpZ3VyYXRpb24pLgo+IAo+IFN0b3AgcmVxdWVzdGluZyBh bmQgZW5hYmxpbmcgdGhlIGNhbF9zbGVlcCBjbG9jay4KPiAKPiBBc3Npc3RlZC1ieTogQ2xhdWRl OmNsYXVkZS1mYWJsZS01Cj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IEJhcnlzaGtvdiA8ZG1pdHJ5 LmJhcnlzaGtvdkBvc3MucXVhbGNvbW0uY29tPgoKUmV2aWV3ZWQtYnk6IE1hbml2YW5uYW4gU2Fk aGFzaXZhbSA8bWFuaXZhbm5hbi5zYWRoYXNpdmFtQG9zcy5xdWFsY29tbS5jb20+CgotIE1hbmkK Ci0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+N CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK