From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CC846AA79; Mon, 12 Oct 2026 08:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791794714; cv=none; b=AJxeeWGS3F0fhaYvtn5HLPLuLtaXfH/o7BPukk3HoWy9cs58rvdymndLmlXvfzW3GF9rzsILU/V0VsBQTBOl8bSiK1BzePNRVfaaIOyYAahCoD7t+zxj/tIqBGuDyJeY6ev8qI6BZOz7vMTJ99lRDnAIBBpL9Y8UJamHVlVvSQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791794714; c=relaxed/simple; bh=hig3XniRR/HDfZHucwWx80FgVL/trsWH9Wxj+J7sKOo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NpAAt2TR0mc2ykv9ii9vLcYU3c0w4ulihGfH2FZIK5GXMbijaygdmvRY6MAds9w2zLzfVjEhnMzglqOuAh0+mxnA2lcGhmhKy2PR0XRoPivTPw0R97LvvqUf523pNaM7FKMwskdCFvdl0oXsIBOrBDFCosQ5VpbA3X/ZRtqVjeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y5RvL1Sr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y5RvL1Sr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F17EF1F0089B; Mon, 12 Oct 2026 08:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791794712; bh=mLq/ymuCxjQn6Fzuy7KDen+WF8JmVHF/Ne4WHKOpXH8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Y5RvL1SrOadQ661Atpug9vUhm8R68LIzDdNNQP6l/xanOO4p9RnJNrWjpdsH2fyh8 AHv7N7XQHhr5E2H+q/DiKsUTsFNUMFfl3l5Oexgp7GGtVfXHZrlTkrRvINDnpIH1LF xBKJf4vXeUSYxcIO37YNI90Qo1tovx9xysOWB54fc23x8EecvHidGoiVTxfT1RWF++ hILSrrQCZHzLz2O2iM09gbnvtyv45YrqtjEIK6uy4HwBEvX+8eIG4VkXzFqQ5lLF25 Rh5ad5B+B2CE08yRfGAEdw/d7azKCkfmyOXzGZci21h+b1Tiuj/3susKvIA7vd5P3z 9opJsy4OFHoSw== Date: Mon, 12 Oct 2026 14:14:59 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen Subject: Re: [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Message-ID: References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-6-e5f93ea76ffa@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260810-msm8974-usb-hsic-v1-6-e5f93ea76ffa@oss.qualcomm.com> On Mon, Aug 10, 2026 at 06:42:10PM +0300, Dmitry Baryshkov wrote: > The msm chipidea glue enables runtime PM with pm_runtime_no_callbacks() > and nothing pinning it active. Right after a successful probe the > driver core's pm_request_idle() runtime-suspends the glue (the ci core > child has runtime PM disabled, so it does not hold its parent), Why does the child's runtime PM disabled first of all? > and > when the glue sits in a power domain - the HSIC instances live in the > USB_HS_HSIC GDSC on msm8974 - genpd then powers the domain off > underneath the running controller. The EHCI register file reads back > zeroes, an onboard hub's connect is never seen, and subsequent bus > accesses into the unpowered block wedge the interconnect, eventually > taking the whole SoC down. > > Pin the glue runtime-active so the domain stays powered for the > lifetime of the controller. Proper low-power handling can later be > built on the child's runtime PM together with the HSIC wakeup > interrupt. > The commit message confuses between PM runtime 'active' and 'usage count'. Marking a device as runtime PM 'active' wouldn't prevent it from being suspended, but only increasing it's 'usage count' will. Which is what this patch is doing btw, but just that the terminology is not correct. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52A7CCA9ED1 for ; Mon, 12 Oct 2026 08:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4W7EyKD3+SRcLZELZLAzjXsrQc9l4Ie6GVuMWOVeFVw=; b=XC4vkADZ7PJvxE 3kPGct8y+ut72+QR4+SGULJuantfnXhAm84G+8wwKy0z/8X3nGbEed4NoNTihQO5dGy6PCiCmunwb ibMqP/slJppqmF/su8LdKGkEo0FyvkT7haOB13yZRPKRdEgVj2ip+1nB7Mb7Qw9BNupUXv41mjw1V 2re+R9vDAPjO6+/gFbrh86VEsr+7LFdBq4zFFwlJ4XhcBWfKFjffAD1ua0halsMQMrRA2UtpZgBLg SaIsufFMzmHszN5JQr3CQPY2G7jqvKAb3fE3wwbPfujmMJ21Z3YkiyYRIBjRzp56l53gLH1icNLhy CKycj9yb/K15xThXsJCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBel-00000009yid-04Y3; Mon, 12 Oct 2026 08:45:15 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGBej-00000009yi1-22gm for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 08:45:13 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D46D540F18; Mon, 12 Oct 2026 08:45:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F17EF1F0089B; Mon, 12 Oct 2026 08:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791794712; bh=mLq/ymuCxjQn6Fzuy7KDen+WF8JmVHF/Ne4WHKOpXH8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Y5RvL1SrOadQ661Atpug9vUhm8R68LIzDdNNQP6l/xanOO4p9RnJNrWjpdsH2fyh8 AHv7N7XQHhr5E2H+q/DiKsUTsFNUMFfl3l5Oexgp7GGtVfXHZrlTkrRvINDnpIH1LF xBKJf4vXeUSYxcIO37YNI90Qo1tovx9xysOWB54fc23x8EecvHidGoiVTxfT1RWF++ hILSrrQCZHzLz2O2iM09gbnvtyv45YrqtjEIK6uy4HwBEvX+8eIG4VkXzFqQ5lLF25 Rh5ad5B+B2CE08yRfGAEdw/d7azKCkfmyOXzGZci21h+b1Tiuj/3susKvIA7vd5P3z 9opJsy4OFHoSw== Date: Mon, 12 Oct 2026 14:14:59 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Xu Yang , Peng Fan , Vinod Koul , Neil Armstrong , Peter Chen , Pavankumar Kondeti , Stephen Boyd , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, Greg Kroah-Hartman , Peter Chen Subject: Re: [PATCH 06/10] usb: chipidea: msm: keep the glue device runtime-active Message-ID: References: <20260810-msm8974-usb-hsic-v1-0-e5f93ea76ffa@oss.qualcomm.com> <20260810-msm8974-usb-hsic-v1-6-e5f93ea76ffa@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260810-msm8974-usb-hsic-v1-6-e5f93ea76ffa@oss.qualcomm.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMTAsIDIwMjYgYXQgMDY6NDI6MTBQTSArMDMwMCwgRG1pdHJ5IEJhcnlzaGtv diB3cm90ZToKPiBUaGUgbXNtIGNoaXBpZGVhIGdsdWUgZW5hYmxlcyBydW50aW1lIFBNIHdpdGgg cG1fcnVudGltZV9ub19jYWxsYmFja3MoKQo+IGFuZCBub3RoaW5nIHBpbm5pbmcgaXQgYWN0aXZl LiBSaWdodCBhZnRlciBhIHN1Y2Nlc3NmdWwgcHJvYmUgdGhlCj4gZHJpdmVyIGNvcmUncyBwbV9y ZXF1ZXN0X2lkbGUoKSBydW50aW1lLXN1c3BlbmRzIHRoZSBnbHVlICh0aGUgY2kgY29yZQo+IGNo aWxkIGhhcyBydW50aW1lIFBNIGRpc2FibGVkLCBzbyBpdCBkb2VzIG5vdCBob2xkIGl0cyBwYXJl bnQpLAoKV2h5IGRvZXMgdGhlIGNoaWxkJ3MgcnVudGltZSBQTSBkaXNhYmxlZCBmaXJzdCBvZiBh bGw/Cgo+IGFuZAo+IHdoZW4gdGhlIGdsdWUgc2l0cyBpbiBhIHBvd2VyIGRvbWFpbiAtIHRoZSBI U0lDIGluc3RhbmNlcyBsaXZlIGluIHRoZQo+IFVTQl9IU19IU0lDIEdEU0Mgb24gbXNtODk3NCAt IGdlbnBkIHRoZW4gcG93ZXJzIHRoZSBkb21haW4gb2ZmCj4gdW5kZXJuZWF0aCB0aGUgcnVubmlu ZyBjb250cm9sbGVyLiBUaGUgRUhDSSByZWdpc3RlciBmaWxlIHJlYWRzIGJhY2sKPiB6ZXJvZXMs IGFuIG9uYm9hcmQgaHViJ3MgY29ubmVjdCBpcyBuZXZlciBzZWVuLCBhbmQgc3Vic2VxdWVudCBi dXMKPiBhY2Nlc3NlcyBpbnRvIHRoZSB1bnBvd2VyZWQgYmxvY2sgd2VkZ2UgdGhlIGludGVyY29u bmVjdCwgZXZlbnR1YWxseQo+IHRha2luZyB0aGUgd2hvbGUgU29DIGRvd24uCj4gCj4gUGluIHRo ZSBnbHVlIHJ1bnRpbWUtYWN0aXZlIHNvIHRoZSBkb21haW4gc3RheXMgcG93ZXJlZCBmb3IgdGhl Cj4gbGlmZXRpbWUgb2YgdGhlIGNvbnRyb2xsZXIuIFByb3BlciBsb3ctcG93ZXIgaGFuZGxpbmcg Y2FuIGxhdGVyIGJlCj4gYnVpbHQgb24gdGhlIGNoaWxkJ3MgcnVudGltZSBQTSB0b2dldGhlciB3 aXRoIHRoZSBIU0lDIHdha2V1cAo+IGludGVycnVwdC4KPiAKClRoZSBjb21taXQgbWVzc2FnZSBj b25mdXNlcyBiZXR3ZWVuIFBNIHJ1bnRpbWUgJ2FjdGl2ZScgYW5kICd1c2FnZSBjb3VudCcuCk1h cmtpbmcgYSBkZXZpY2UgYXMgcnVudGltZSBQTSAnYWN0aXZlJyB3b3VsZG4ndCBwcmV2ZW50IGl0 IGZyb20gYmVpbmcKc3VzcGVuZGVkLCBidXQgb25seSBpbmNyZWFzaW5nIGl0J3MgJ3VzYWdlIGNv dW50JyB3aWxsLiBXaGljaCBpcyB3aGF0IHRoaXMgcGF0Y2gKaXMgZG9pbmcgYnR3LCBidXQganVz dCB0aGF0IHRoZSB0ZXJtaW5vbG9neSBpcyBub3QgY29ycmVjdC4KCi0gTWFuaQoKLS0gCuCuruCu o+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXgrq7gr40KCi0tIApsaW51 eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=