Re: [PATCH] coco/tdx-host: add Kconfig description

[Kiryl Shutsemau <kas@kernel.org>]

On Sun, Oct 04, 2026 at 12:32:37AM +0200, Dmitry Voytik wrote:
> Fix the issue when the driver always gets compiled as a module.
> How to reproduce the issue:
> 	make mrproper
> 	make defconfig
> 
> 	./scripts/config \
> 	  -e CMA \
> 	  -e ALLOC \
> 	  -e KVM \
> 	  -e KVM_INTEL \
> 	  -e KVM_INTEL_TDX \
> 	  -e INTEL_TDX_HOST \
> 	  -e TDX_HOST_SERVICES \
> 	  --refresh
> 	make olddefconfig
> 	make mod2yesconfig
> 	grep '=m$' .config
> 
> 	returns only this driver as module:
> 	  CONFIG_TDX_HOST_SERVICES=m
> 
> "make menuconfig" doesn't let switch from =m to =y either.
> 
> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
> ---
>  drivers/virt/coco/tdx-host/Kconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/virt/coco/tdx-host/Kconfig b/drivers/virt/coco/tdx-host/Kconfig
> index 57d0c01a4357..5a13ec6f51e8 100644
> --- a/drivers/virt/coco/tdx-host/Kconfig
> +++ b/drivers/virt/coco/tdx-host/Kconfig
> @@ -1,6 +1,10 @@
>  config TDX_HOST_SERVICES
> -	tristate
> +	tristate "TDX host user interface driver"
>  	depends on INTEL_TDX_HOST
>  	select FW_LOADER
>  	select FW_UPLOAD
>  	default m
> +	help
> +	  See INTEL_TDX_HOST for details.
> +
> +	  If unsure, say N.

I would rather keep it hidden and make it follow KVM_INTEL instead:

config TDX_HOST_SERVICES
        tristate
        depends on INTEL_TDX_HOST
        select FW_LOADER
        select FW_UPLOAD
        default KVM_INTEL

INTEL_TDX_HOST depends on KVM_INTEL, so this gives =m with kvm-intel as a
module and =y with it built in, which covers your mod2yesconfig case.

Does it work for you?

-- 
  Kiryl Shutsemau / Kirill A. Shutemov